fix: remove dead links to deleted translation_*.md files#662
Open
0xDevNinja wants to merge 1 commit intotc39:mainfrom
Open
fix: remove dead links to deleted translation_*.md files#6620xDevNinja wants to merge 1 commit intotc39:mainfrom
0xDevNinja wants to merge 1 commit intotc39:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit
ef93571("Removetranslation_*.md") deleted the per-language translation docs (translation_de.md,translation_ja.md,translation_ru.md,translation_uk.md,translation_fr.md,translation_zh-Hans.md), but several references to those files were left behind and now point at 404s. This PR repoints those references at the surviving roottranslation.md, drops the now-dead "See the X Translation documentation" lines fromtranslation.md, and fixes a couple of small adjacent issues spotted in the same file.Changes
translation.mdSee the [X Translation documentation](translation_X.md)lines (all targets are deleted).### German transation:→### German Translation:.### Traditional Chinese Translation:→### Simplified Chinese Translation:(the section is forzh-Hans, which is Simplified)._data/en/stage3.yml→_data/en/stage3.json_data/languages.yml→_data/languages.json(Both files are JSON in the repo; the
.ymlreferences are leftovers from before the Eleventy migration.){de,ja,ru,zh-Hans,uk}/proposals.jsonFor each locale, repoint two fields at the surviving doc:
needs_translation_url:…/translation_<lang>.md→…/translation.mdcommunity_translations: the embedded<a href="…/translation_<lang>.md">link is repointed the same way.fr/anden/already point attranslation.md; no change needed there.Out of scope (deliberately not in this PR)
de/site.jsonfooter.coc,zh-Hans/site.jsonfooter.coc, andfr/proposals.jsonspecification— those are real but unrelated to dead-link cleanup.Test plan
grep -r 'translation_.*\.md' translation.md {de,fr,ja,ru,zh-Hans,uk,en}/proposals.json README.mdreturns no matches after the change.npm run buildsucceeds;_site/{en,de,fr,ja,ru,zh-Hans,uk}/index.htmlrender normally.