fix #300, extract language icon and remove stray copyright#661
Open
0xDevNinja wants to merge 1 commit intotc39:mainfrom
Open
fix #300, extract language icon and remove stray copyright#6610xDevNinja wants to merge 1 commit intotc39:mainfrom
0xDevNinja wants to merge 1 commit intotc39:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses parts of #300:
_layouts/menu.htmlinto a new fileassets/img/language.svg, matching the existing<img src="/assets/img/...">pattern used bylogo.svg/ecma-logo.svg. Drops the inlinerole="button"(the new<img>carries its own role and gets a localizedalt).<!-- Copyright © 2015 Apple Inc. All rights reserved. -->comment and redundant<?xml version="1.0" encoding="utf-8"?>preamble /version="1.1"attribute fromassets/img/menu-down.svg._sass/_page-menu.scssto target.menu-link__language imginstead of the now-removed inlinesvg.Left for follow-up
logo.svgviewBoxconcern raised in inconsistent use of language selector icon & other SVG asset problems #300 — a quick eyeball of the rendered logo before/after didn't show an obvious problem, so I didn't change it. Worth a separate PR with a clear visual diff.ecma-logo.svg,logo.svg) — left as a follow-up to keep this PR focused.site.jsonfiles don't definenavigation.language.title, so the<img alt>ends up empty for them. That mirrors the prior behavior of the.menu-link__language-textspan and is a translation-data gap, not an asset issue.Test plan
npm run lintpassesnpm run buildsucceeds; rendered_site/index.html,_site/en/index.html,_site/zh-Hans/index.htmlall reference/assets/img/language.svgvia<img>assets/css/style.cssregen (sass version bump produced unrelated diffs)