Work around Firefox bug with 'gregory' calendar era names
#2033
Conversation
Works around https://bugzilla.mozilla.org/show_bug.cgi?id=1752253 by allowing either 'a' or 'ad' for the CE era and 'b' or 'bc' for the BCE era.
Codecov Report
@@ Coverage Diff @@
## main #2033 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 19 19
Lines 10989 10993 +4
Branches 1596 1597 +1
=======================================
+ Hits 10379 10383 +4
Misses 590 590
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Do the existing tests cover it, if they were run in firefox? |
justingrant
changed the title
'gregory' calendar era names
justingrant
added
no-spec-text
Yes. There would be massive failures all over the place because this bug prevents the |
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Ah, I hit that somewhere. Thanks for figuring it out!
3 participants
Works around https://bugzilla.mozilla.org/show_bug.cgi?id=1752253 by allowing either
'a'or'ad'for the CE era and'b'or'bc'for the BCE era.This bug only occurs with Firefox and our tests don't use FF, so there wasn't any way to add a test for it. But I did verify it on the docs playground and it works great in FF 97.
Fixes #2020.