Skip to content

Copy options object for PlainYearMonth.{add,subtract} and InterpretTemporalDateTimeFields #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptomato merged 1 commit into from
Sep 17, 2021
Merged

Copy options object for PlainYearMonth.{add,subtract} and InterpretTemporalDateTimeFields #1748

ptomato merged 1 commit into from
Sep 17, 2021

Conversation

@cjtenny
Copy link
Collaborator

@cjtenny cjtenny commented Aug 19, 2021

… to prevent user-modified objects from interfering with later operations.

Fixes #1686

@cjtenny cjtenny requested a review from ptomato August 19, 2021 23:20
@codecov
Copy link

codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #1748 (0b44710) into main (8b90758) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 0b44710 differs from pull request most recent head e9fe915. Consider uploading reports for the commit e9fe915 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
+ Coverage   94.79%   94.96%   +0.17%     
==========================================
  Files          19       19              
  Lines       10963    10962       -1     
  Branches     1713     1740      +27     
==========================================
+ Hits        10392    10410      +18     
+ Misses        556      537      -19     
  Partials       15       15
Flag Coverage Δ
test262 78.78% <100.00%> (-2.40%) ⬇️
tests 90.11% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/ecmascript.mjs 95.07% <100.00%> (+0.09%) ⬆️
polyfill/lib/plainyearmonth.mjs 96.44% <100.00%> (+0.56%) ⬆️
polyfill/lib/calendar.mjs 94.43% <0.00%> (+0.13%) ⬆️
polyfill/lib/plainmonthday.mjs 93.91% <0.00%> (+6.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b90758...e9fe915. Read the comment docs.

ljharb
ljharb reviewed Aug 19, 2021
View reviewed changes
ptomato
ptomato reviewed Aug 20, 2021
View reviewed changes
@ptomato
Copy link
Collaborator

ptomato commented Aug 20, 2021

Marking the normative PR as draft to avoid accidental merging

@ptomato ptomato marked this pull request as draft August 20, 2021 01:02
@ptomato ptomato marked this pull request as ready for review August 31, 2021 19:08
@ptomato
Copy link
Collaborator

ptomato commented Aug 31, 2021

This change achieved consensus in TC39. Can be merged when the wording issues are addressed and the tests are added.

@cjtenny cjtenny requested a review from ptomato September 1, 2021 07:59
ptomato
ptomato approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment on the tests.

ljharb
ljharb reviewed Sep 3, 2021
View reviewed changes
@Ms2ger Ms2ger mentioned this pull request Sep 16, 2021
Merged
@12wrigja 12wrigja mentioned this pull request Sep 17, 2021
Closed
@ptomato ptomato force-pushed the cjtenny/fix-1686 branch 2 times, most recently from d9e9fce to 9491256 Compare September 17, 2021 20:04
@cjtenny @ptomato
Copy options object for PlainYearMonth.{add,subtract} and InterpretTe…
e9fe915 
…mporalDateTimeFields to prevent user-modified objects from interfering with later operations.

Fixes #1686
@ptomato ptomato merged commit be88667 into main Sep 17, 2021
@ptomato ptomato deleted the cjtenny/fix-1686 branch September 17, 2021 21:37
@ptomato ptomato added the spec-text Specification text involved label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments

@ptomato ptomato ptomato approved these changes

Assignees

No one assigned

Labels

spec-text Specification text involved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure the same object is not passed twice into user code

4 participants

@cjtenny @ptomato @ljharb