Conversation
ryzokuken
approved these changes
May 6, 2024
Comment on lines
+901
to
+902
| 1. Let _locales_ be CreateArrayFromList(_ctx_.[[MessageFormat]].[[RequestedLocales]]). | ||
| 1. Perform ! CreateDataPropertyOrThrow(_funcCtx_, *"locale"*, _locales_). |
Member
There was a problem hiding this comment.
Any specific reason for breaking this line up? FWIW I don't mind either way, just curious.
Member
Author
There was a problem hiding this comment.
Note that previously we didn't have a CreateArrayFromList() call here; that was due to the bug noted in #52. So I added it here to also ensure that each time we're passing in a new array to the called function, which previously would've been available for use as a communication channel.
As for splitting up the line, it just got a bit too long for comfort when including the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Closes #55
Replaces #57