Skip to content

Make [[RequestedLocales]] an Array#57

Closed
eemeli wants to merge 4 commits intomainfrom
requested-locales-array
Closed

Make [[RequestedLocales]] an Array#57
eemeli wants to merge 4 commits intomainfrom
requested-locales-array

Conversation

@eemeli
Copy link
Copy Markdown
Member

@eemeli eemeli commented Apr 26, 2024

Fixes #52

@eemeli eemeli requested a review from FrankYFTang April 26, 2024 06:41
@FrankYFTang
Copy link
Copy Markdown
Contributor

This fix is not good enough because in https://tc39.es/proposal-intl-messageformat/#sec-properties-of-intl-messageformat-instances

[[RequestedLocales]] is a List of String values with the canonicalized language tags of the requested locales to use for message formatting.

and you now create an array and assign to a [[RequestedLocales]].

If you want to make [[RequestedLocales]] an array, you also need to change the above line

@eemeli
Copy link
Copy Markdown
Member Author

eemeli commented Apr 30, 2024

Good catch, thank you! @FrankYFTang, PTAL?

</li>
<li>
[[RequestedLocales]] is a List of String values
[[RequestedLocales]] is an Array of String values
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nowhere in ECMA402 mention "an Array of String" . In ECMA262, I find one place and it use the wording "an Array of Strings" instead of "an Array of String values"
See https://tc39.es/ecma262/#sec-json.stringify

@eemeli
Copy link
Copy Markdown
Member Author

eemeli commented May 7, 2024

This was obsoleted by #63.

@eemeli eemeli closed this May 7, 2024
@eemeli eemeli deleted the requested-locales-array branch May 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[[RequestedLocales]] cannot be passed to CreateDataPropertyOrThrow as V

3 participants