Editorial: A few spec text fixes found during implementation#126
Open
Editorial: A few spec text fixes found during implementation#126
Conversation
We just constrained the month before this step.
This step was the only one which did not end with "to ignoredKeys".
The only caller (CalendarDateAdd) performs this check on the result.
ptomato
requested changes
Mar 10, 2026
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks for catching these! Other than the NonISODateAdd change, I'll tack them on to the stage 4 PR.
| 1. Let _result_ be ? CalendarIntegersToISO(_calendar_, _balancedDate_.[[Year]], _balancedDate_.[[Month]], _balancedDate_.[[Day]]). | ||
| 1. If ISODateWithinLimits(_result_) is *false*, throw a *RangeError* exception. | ||
| 1. Return _result_. | ||
| 1. Return ? CalendarIntegersToISO(_calendar_, _balancedDate_.[[Year]], _balancedDate_.[[Month]], _balancedDate_.[[Day]]). |
Collaborator
There was a problem hiding this comment.
I'd prefer to keep this as is, in analogy to CalendarDateAdd.
ptomato
reviewed
Mar 10, 2026
| 1. Else, | ||
| 1. Let _month_ be _fields_.[[Month]]. | ||
| 1. Let _daysInMonth_ be CalendarDaysInMonth(_calendar_, _fields_.[[Year]], _fields_.[[Month]]). | ||
| 1. Let _daysInMonth_ be CalendarDaysInMonth(_calendar_, _fields_.[[Year]], _month_). |
Collaborator
There was a problem hiding this comment.
(This one is already fixed in the stage 4 PR. I must have forgotten to port it back here.)
ptomato
added a commit
to ptomato/ecma402
that referenced
this pull request
Mar 10, 2026
See tc39/proposal-intl-era-monthcode#126 h/t Tim Flynn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed a few things while implementing non-ISO-8601 support for LibJS.