Conversation
ordinal months greater than the number of months in the year in that calendar for the specified year.
ptomato
reviewed
Feb 25, 2026
| 1. Let _month_ be _monthsInYear_. | ||
| 1. Else, | ||
| 1. Let _month_ be _fields_.[[Month]]. | ||
| 1. Let _daysInMonth_ be CalendarDaysInMonth(_calendar_, _fields_.[[Year]], _fields_.[[Month]]). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. Let _daysInMonth_ be CalendarDaysInMonth(_calendar_, _fields_.[[Year]], _fields_.[[Month]]). | |
| 1. Let _daysInMonth_ be CalendarDaysInMonth(_calendar_, _fields_.[[Year]], _month_). |
I noticed this while integrating it into tc39/ecma402#1044. I've fixed it up there.
ptomato
added a commit
to ptomato/ecma402
that referenced
this pull request
Feb 25, 2026
This was referenced Feb 25, 2026
ptomato
added a commit
to ptomato/proposal-intl-era-monthcode
that referenced
this pull request
Mar 4, 2026
Similar to tc39#122, the change there must also apply here. Editorial because otherwise we fail an assertion. h/t fabon-f
ptomato
added a commit
to ptomato/proposal-intl-era-monthcode
that referenced
this pull request
Mar 4, 2026
Similar to tc39#122, the change there must also apply here. Editorial because otherwise we fail an assertion. h/t fabon-f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a spec bug identified in #121, which resulted in assertion violations when user provides a date with a month greater than the number of months in that year for that calendar.