Conversation
ptomato
approved these changes
Feb 18, 2026
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Looks great. I think it makes sense to split out the *"chinese"*/*"dangi"* case in this way, and it's easy to verify that the other calendars are left unchanged.
Collaborator
… the East Asian lunisolar calendars is used, and wherein a year is given. Desired behaviour is to follow the table of valid reference years in this case, which was previously overlooked.
ptomato
force-pushed
the
issue-113-NonISOMonthDayToISOReferenceDate
branch
from
e94d67d to
e9aae22
Compare
Contributor
|
I believe this matches V8's behavior already because temporal_rs will first fully resolve the date and then loop back and try to get a MonthDay from it. |
jessealama
added a commit
to jessealama/test262
that referenced
this pull request
Feb 25, 2026
Test the fix from tc39/proposal-intl-era-monthcode#118: NonISOMonthDayToISOReferenceDate should always use the reference year table for Chinese/Dangi, not the provided year.
ptomato
added a commit
to ptomato/proposal-intl-era-monthcode
that referenced
this pull request
Mar 4, 2026
Makes the behaviour of the chinese/dangi clause correspond to the non-chinese/dangi clause. This fixes an unintended regression from tc39#118. h/t fabon-f
ptomato
added a commit
to ptomato/proposal-intl-era-monthcode
that referenced
this pull request
Mar 4, 2026
Makes the behaviour of the chinese/dangi clause correspond to the non-chinese/dangi clause. This fixes an unintended regression from tc39#118. h/t fabon-f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix:
Previously in
NonISOMonthDayToISOReferenceDatewhen:the spec failed to indicate that the table of reference years for these calendars should be used. This oversight made the AO unimplementable. This PR corrects that.
fix #113