ES2017 review, second round#799
Closed
anba wants to merge 47 commits intotc39:masterfrom
Closed
Conversation
…elModuleEvaluationJob
…t|Set)ValueFromBuffer has additional memory order parameters
… ArrayBuffer.prototype.slice
…dArrayBuffer.prototype.slice
…redArrayBuffer [ @@species ]'
…fers overview Because it is redundant (and strictly speaking incorrect during initialisation).
…cting use of 'range' in other parts of the spec
azu
reviewed
Feb 6, 2017
| ======= | ||
| 1. If both IsSharedArrayBuffer(_srcBuffer_) and IsSharedArrayBuffer(_targetBuffer_) are *true*, and _srcBuffer_.[[ArrayBufferData]] is equal to _targetBuffer_.[[ArrayBufferData]], let _same_ be *true*, else let _same_ be SameValue(_srcBuffer_, _targetBuffer_). | ||
| 1. If _same_ is *true*, then | ||
| >>>>>>> e90f50b... Remove 'then' in single-line if-steps |
Contributor
Author
There was a problem hiding this comment.
Thanks, probably happened while reordering the commits. Will fix and rebase.
Contributor
Author
There was a problem hiding this comment.
force rebased to remove the conflict marker
…from Atomics.wait
…consistency with other callers Also rename the temporary variable to have a more meaningful name.
…t, because it's not marked as optional
…s not marked as optional
…byte values list in Atomics.compareExchange
…ther global objects
ea7479b to
4e3f855
Compare
Member
|
I've pulled all these in (ordered, rebased, minus the double-a commit which was already fixed). Find the last commit here: 581023c. |
ptomato
pushed a commit
to ptomato/ecma262
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly fixes nits in the Atomics and memory model chapters.