Skip to content

ES2017 review, second round#799

Closed
anba wants to merge 47 commits intotc39:masterfrom
anba:es2017-review-second-round
Closed

ES2017 review, second round#799
anba wants to merge 47 commits intotc39:masterfrom
anba:es2017-review-second-round

Conversation

@anba
Copy link
Copy Markdown
Contributor

@anba anba commented Feb 6, 2017

Mostly fixes nits in the Atomics and memory model chapters.

anba added 26 commits February 6, 2017 11:44
…t|Set)ValueFromBuffer has additional memory order parameters
…fers overview

Because it is redundant (and strictly speaking incorrect during initialisation).
…cting use of 'range' in other parts of the spec
Comment thread spec.html Outdated
=======
1. If both IsSharedArrayBuffer(_srcBuffer_) and IsSharedArrayBuffer(_targetBuffer_) are *true*, and _srcBuffer_.[[ArrayBufferData]] is equal to _targetBuffer_.[[ArrayBufferData]], let _same_ be *true*, else let _same_ be SameValue(_srcBuffer_, _targetBuffer_).
1. If _same_ is *true*, then
>>>>>>> e90f50b... Remove 'then' in single-line if-steps
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, probably happened while reordering the commits. Will fix and rebase.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force rebased to remove the conflict marker

anba added 18 commits February 6, 2017 12:56
…consistency with other callers

Also rename the temporary variable to have a more meaningful name.
@anba anba force-pushed the es2017-review-second-round branch from ea7479b to 4e3f855 Compare February 6, 2017 10:58
@bakkot bakkot added the needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 label Feb 8, 2017
@bterlson
Copy link
Copy Markdown
Member

I've pulled all these in (ordered, rebased, minus the double-a commit which was already fixed). Find the last commit here: 581023c.

@bterlson bterlson closed this Mar 21, 2017
ptomato pushed a commit to ptomato/ecma262 that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants