feat(bundler): Add Pacman Packaging, closes #3728 , #4301#8656
Open
naman-crabnebula wants to merge 12 commits intotauri-apps:1.xfrom
Open
feat(bundler): Add Pacman Packaging, closes #3728 , #4301#8656naman-crabnebula wants to merge 12 commits intotauri-apps:1.xfrom
naman-crabnebula wants to merge 12 commits intotauri-apps:1.xfrom
Conversation
Contributor
Author
|
Btw, the docs needs to be updated as well |
amrbashir
requested changes
Jan 29, 2024
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Looks like you're targeting 1.x branch, we should target dev instead.
| /// Returns a vector of PathBuf that shows where the archive.tar.gz was created. | ||
| pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<PathBuf>> { | ||
| let arch = match settings.binary_arch() { | ||
| // Arch Linux recognises `x86_64` and `aarch64` instead of `amd64` and `arm64` respectively. |
Member
There was a problem hiding this comment.
Suggested change
| // Arch Linux recognises `x86_64` and `aarch64` instead of `amd64` and `arm64` respectively. | |
| // Arch Linux recognizes `i386` instead of `x86`. |
|
|
||
| let (data_dir, _) = generate_data(settings, &package_dir) | ||
| .with_context(|| "Failed to build data folders and files")?; | ||
| copy_custom_files(settings, &data_dir).with_context(|| "Failed to copy custom files")?; |
Member
There was a problem hiding this comment.
this will use files under deb config, we should add a files option for pacman instead and change copy_custom_files function to be more generic, we should do the same for appimage as well
13 tasks
|
any updates on this getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great News for Arch Linux users!
Tauri is going to support Arch Linux packages by default 🎉
Although docs are yet to be added, you all are welcome to test the new changes.
If you face any issue / want to request additional features, feel free to add your comments.
Thank You