I wonder if we should use Self::Txt as a general fallback instead of Self::Html 🤔 Not sure what depends on that though so maybe something to think about later when Lucas is back.

Pushed a fixup to fix the linter error. Unfortunately the 'test core' jobs are failing with:

error: package `cargo_toml v0.15.3` cannot be built because it requires rustc 1.64 or newer, while the currently active rustc version is 1.60.0

i want to cry 😂

Can you add the package to this list: https://github.com/tauri-apps/tauri/blob/dev/.github/workflows/test-core.yml#L95 pinning it to 0.15.2 please?

Done. It was cargo update -p cargo_toml:0.15.3 --precise 0.15.2 due to:

error: There are multiple `cargo_toml` packages in your project, and the specification `cargo_toml` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  cargo_toml:0.11.8
  cargo_toml:0.15.3

Okay, now there's that other Clippy failure.

I can reproduce the tauri-codegen warning on dev by running cargo clippy --manifest-path core/tauri/Cargo.toml -- -D warnings. Since it's set to fail on warnings, I assume that's the problem rather than the PR-from-fork stuff.

Yeah, don't worry about it. Since your change doesn't trigger it we can fix it in another PR :)

For Tauri itself I think it's fine to change the default fallback to txt (I hope the asset will always have the .html extension), though for users it might be a little weird. The fallback for tauri://localhost should be indeed html instead of txt.

I'm thinking about it and it should be a separate PR (maybe even targetting v2 instead with a better way of handling this).

Why though? When would falling back to text be worse than falling back to html? Or different: When do we want to send html for non html files?

Genuine question btw, i'm so out of the loop on this topic by know that i can't think of a use-case right now.

MimeType::parse_from_uri is used when we can't determine the mime type from the file contents (which is always the case unless we do some custom html detection logic). When we receive a request to tauri://localhost, we want to serve it as HTML instead of plain text (I think in some contexts that is required).

hmm, i thought we always tried to load index.html in these cases, or well, i guess we do but the other way around? idk, probably not much of a problem anyway now that we handle text files 🤷