feat(bundler): Add RPM packaging, closes #4402#5202
feat(bundler): Add RPM packaging, closes #4402#5202FabianLars merged 3 commits intotauri-apps:devfrom
Conversation
|
Are there any updates on this PR? Just checking to see what the current status is and if any help is needed. |
059aa8d to
c84da1c
Compare
|
@PyRo1121 Thank you for your message. Actually, I was waiting for 2 two things before completing this work:
I just rebased the PR to fix conflicts. |
Yes! I was/We were primarily waiting for you to consider this PR to be ready for review (besides being busy with other stuff) :) If you think it's ready for a first round of reviews then i'll add it to my todo list and i'm sure one of the others would take a look as well :) P.S. thank you so much for your contribution to Tauri ❤️ |
|
Thank you @FabianLars for your kind response. |
|
What is status this feature? I'm hope then that will be fast into tauri |
c078475 to
f5530cc
Compare
|
Hi @Apogeum12, I've just rebased the PR and updated it to use the crate I should now be able to fix the remaining missing points (cf initial comment). |
|
Hello @olivierlemasle ! Thanks for your work on bringing this feature into Tauri. :) Do you currently have any approximate ETA for when this PR will be review-ready? |
74cc9ab to
b9633fa
Compare
|
@devpikachu @FabianLars Sorry for the delay, I've just rebased and updated the PR, which is now ready for review. |
0ed7281 to
8d3789f
Compare
|
this would be really nice, good work olivierlemasle |
|
Just so you know we're not ignoring you, i will take a look next week when we're back from EuroRust. But from what i've seen so far, awesome work!! |
FabianLars
left a comment
There was a problem hiding this comment.
Sorry for the long delay.
All in all it looks good to me. Api/Config wise i think it's good to go.
The only question i have is about the dependencies notation. Is the .so and bits stuff really required? Shouldn't just webkit2gtk4.1 for example work just as well? Or are there contexts where this won't work, or some general guidelines/best practices i'm not aware of?
|
so whats the exact problem currently @olivierlemasle |
|
Thank you @FabianLars for the review Regarding #8055, @FabianLars do you confirm you prefer merging this PR on RPM, before working on bundle configuration refactoring? Regarding dependency configuration: I used the For example, on Fedora 37 and later, "webkit2gtk 4.1" is provided by a package named
On openSUSE Leap 15, "webkit2gtk 4.1" is provided by a package named
If the RPM contains a dependency to It's the same problem for the other dependencies:
A better solution may exist, but using the |
|
I've just rebased on latest |
|
Also updated crate
|
I don't really care, it's mostly just to make it easier for you and to get this PR merged quicker. Though looking at all the open PRs we should probably merge some more stuff before the refactor to not cause tons of conflicts 😮💨
Thanks for the explanation. I guess i messed up big time because i checked that before asking the question but now i see opensuse being different too so i wonder what the hell i compared fedora too 😂 Anyway, with that done i don't see any blockers here so i'll do another test tomorrow-ish and then it'd be good to go for me. Thanks again for your work :) |
|
Had a quick look (at the PR and the RPM spec) and must admit I am not too familiar with rpm packaging. @FabianLars could you package an example application and verify with Otherwise I think this is a nice addition to the packaging 🤩 |
|
rpmlint only throws error for missing a changelog and a buildhost tag. idk how we'd want to solve this, via simple tauri.conf properties? We don't have any changelog handling anywhere so idk, and a missing buildhost tag almost sounds like a feature to me so we probably don't want to automatically read this from the buildsystem... |
|
FYI, on a simple demo project, rpmlint gives: On the same project, for the There's the same error regarding the absence of changelog. I guess we could indeed add in the future a changelog in Regarding the |
|
Adding a changelog feature which is generic and also makes rpmlint happy might be more trouble than it is worth. RPM changelogs have a standard format with dates and versions in them and it is unlikely more generic changelogs would use this layout. |
…5202) * feat(bundler): Add RPM packaging * feat(bundler): Update 'rpm' to 0.13.1 * Fix fmt
…5202) * feat(bundler): Add RPM packaging * feat(bundler): Update 'rpm' to 0.13.1 * Fix fmt
…5202) * feat(bundler): Add RPM packaging * feat(bundler): Update 'rpm' to 0.13.1 * Fix fmt
* feat(bundler): Add RPM packaging * feat(bundler): Update 'rpm' to 0.13.1 * Fix fmt Co-authored-by: Olivier Lemasle <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
rpmbuild,gpg2or any other external tool.I'm using the crate rpm-rs to build the RPM package. This crate is currently not actively maintained, but a community fork has been created to maintain it in the future.The forked crate, rpm, is now maintained by a community.cargo-bundle(cf Add rpm target support burtonageo/cargo-bundle#115)Status
Provides:andRequires:Closes #4402