fix(shell): Make sidecars work in tests (fix #13767)#3234
fix(shell): Make sidecars work in tests (fix #13767)#3234FabianLars merged 3 commits intotauri-apps:v2from
Conversation
Signed-off-by: Ale Sanchez <[email protected]>
Package Changes Through 8c47c2cThere are 10 changes which include updater with minor, updater-js with minor, barcode-scanner with patch, barcode-scanner-js with patch, http with patch, http-js with patch, sql with patch, sql-js with patch, shell with patch, shell-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
cc @FabianLars just checking in in case you need anything else from my side. I’ve already fixed the tests, so I’m not sure whether there’s something else missing or if you simply haven’t had time to look at it yet. No rush at all! |
|
sorry, been very busy and will be for the next few weeks. will try to squeeze this in when i have a free minute. ironically this change will likely break for users of cargo's new |
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
would you look at that, i have a free minute
Hmm, I see the linked issue... If you think I could help with that, don't hesitate to ping me. I can't promise I'll be able to figure out a solution, but I can definitely try. |
2 participants
The work in this PR is based on this one.
When running tests, using
platform::current_exe().parent()alone is not sufficient, since the executable is located inside thedepsdirectory. To fix this, we need to go up one level.Fixes tauri-apps/tauri#13767