fix(http): ensure body resources are released on stream cancellation#3228
Merged
amrbashir merged 3 commits intotauri-apps:v2from Jan 22, 2026
Merged
fix(http): ensure body resources are released on stream cancellation#3228amrbashir merged 3 commits intotauri-apps:v2from
amrbashir merged 3 commits intotauri-apps:v2from
Conversation
Contributor
Package Changes Through 6198c42There are 8 changes which include updater with minor, updater-js with minor, barcode-scanner with patch, barcode-scanner-js with patch, http with patch, http-js with patch, sql with patch, sql-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Jan 21, 2026
Member
amrbashir
left a comment
There was a problem hiding this comment.
Thank you, I just left one comment to fix the change file.
mrquantumoff
pushed a commit
to mrquantumoff/plugins-workspace
that referenced
this pull request
Jan 26, 2026
…auri-apps#3228) Co-authored-by: Amr Bashir <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a resource management issue where HTTP response bodies were not being properly released if the stream was cancelled by the consumer. By implementing the
cancelhook in theReadableStreamconstructor, we ensure that the internaldropBody()logic is triggered, preventing memory leaks and hanging connections.Problem
Previously, the implementation only handled
AbortSignalevents. However, if a user:reader.cancel(), orfor await...ofloop early viabreakorreturn,The
ReadableStreamwould stop, but the underlying resources managed bydropBody()remained active.Solution
Added the
cancelproperty to theReadableStreamsource object to bridge the gap between the Web Stream lifecycle and our internal resource management.Fixes #3227