I really appreciate the PR but please check out #3184, we've had a slightly different approach in mind.

Thank you for informing me about your approach to this issue. I suppose your way of solving the problem is better than just adding an another feature to the crate. In this case, I'll wait for the official implementation and use my own implementation for the time being.

nono your implementation wasn't that far off. I just wouldn't put it behind a feature flag and instead force the new ids on all users 🤷

one thing that's a bit of an annoyance with zbus is the interface name, i'd like to have that match the dbus name but it needs to be defined at build time if we don't want to code everything ourselves. The spec says "should ..." when it comes to that though so ig it doesn't matter that much

In that case, I'll rework some part of it, to match the intended vision a bit more

I added an option to set the DBus ID at compile time. Made the conventional dbus naming the standard one. I chose to check for DBUS_ID instead of FLATPAK_ID in order to keep better compatibility with people who want to package snaps.

Please document that env var in lib.rs documentation and README.md

As far as i understood it, FLATPAK_ID is set by flatpak at runtime. A compile time env var in my opinion makes little sense and if we want that we should rather have a setter in rust.

Yup, that's actually better

👍 I’ve confirmed that this approach works for releasing new updates on Flathub.

Here’s what needs to be done:

1. When building the Tauri app, set an environment variable, for example: export DBUS_ID=com.bilingify.readest
   The DBUS_ID must exactly match the Flathub app ID defined in the Flatpak manifest YAML file.

2. In the Flatpak manifest, you no longer need to define own-name or talk-name for the D-Bus names.

See https://github.com/flathub/com.bilingify.readest

Package Changes Through 75ea39f

There are 1 changes which include single-instance with minor

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

Sorry for not signing my commits beforehand and for messing up some of the existing ones. I am not used to signing commits with git.

looks like you meant to force-push? your old unsigned commits are still there. I'm very bad with git operations either so i can't really help. I personally would probably reset the branch and copy over the changes manually 😅

On the PR changes themselves. I think we should remove the env var reading. If devs want that they can use the setter with the env!() macro themselves.
For the setter we should not rely on LazyLock (or the once_cell crate if we were to get down the MSRV), but instead use the Builder pattern, with the init function being a shortcut for those not wanting to set the id. I think the opener plugin's code is a fairly good example https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/opener/src/lib.rs#L178-L244

@amrbashir Sorry but i think i'll need your review here since my changes were a bit much x)

Thank you to all involved. This now brings my app to 99% feature parity when running on Flatpak :)