Conversation
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
Looks like it might be eventually consisistent and sometimes return 404 when we know the worker was doing something around that time. We can double-check with checking virtualMachines.get if vm is still there. If both return that instance is gone, we remove it. If not, we tolerate up to 2 times for now this inconsistency in scanner's memory and removing if it fails 3 times in a row
lotas
force-pushed
the
feat/8314-azure-vm-gone-or-still-there-hello-can-you-here-me-major-tom
branch
from
c7f7efd to
1c1d1e6
Compare
matt-boris
approved these changes
Feb 25, 2026
lotas
deleted the
feat/8314-azure-vm-gone-or-still-there-hello-can-you-here-me-major-tom
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it might be eventually consistent and sometimes return 404 when we know the worker was doing something around that time. We can double-check with checking virtualMachines.get if vm is still there. If both return that instance is gone, we remove it. If not, we tolerate up to 2 times for now this inconsistency in scanner's memory and removing if it fails 3 times in a row
Fixes #8314