fix(generic-worker): ensure ProfSvc is running before profile ops#8299
Merged
matt-boris merged 1 commit intomainfrom Feb 20, 2026
Merged
fix(generic-worker): ensure ProfSvc is running before profile ops#8299matt-boris merged 1 commit intomainfrom
ProfSvc is running before profile ops#8299matt-boris merged 1 commit intomainfrom
Conversation
matt-boris
force-pushed
the
matt-boris/gwWinLoadUserProfile
branch
from
b311167 to
5931a1e
Compare
matt-boris
force-pushed
the
matt-boris/gwWinLoadUserProfile
branch
from
5931a1e to
0ed68a0
Compare
matt-boris
requested review from
lotas and
petemoore
and removed request for
a team
matt-boris
commented
Feb 19, 2026
| return pinfo.Profile, nil | ||
| } | ||
|
|
||
| if errno, ok := err.(syscall.Errno); ok && errno == 21 { // ERROR_NOT_READY |
Contributor
Author
There was a problem hiding this comment.
This was always returning as false due to an incorrect error type assertion, so retries were never done. I confirmed in papertail that we never see any logs containing LoadUserProfile failed with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8083 (hopefully 🤞🏻)