feat(queue): Report missing metrics for claim and deadline resolvers#8296
Merged
feat(queue): Report missing metrics for claim and deadline resolvers#8296
Conversation
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
matt-boris
approved these changes
Feb 19, 2026
Contributor
matt-boris
left a comment
matt-boris
left a comment
There was a problem hiding this comment.
Thanks! LGTM
I am beginning to wonder if we're missing metrics: true anywhere else now lol I think this might be the second time something like this has happened :)
Ty for fixing
Contributor
Author
all good, it's not that, those services were not exposing any metrics. So I had to make them report those metrics, and also expose as a service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue_exception_tasksmetric was only reported from queue api endpoint, when workers reported exceptions, but not from the background jobs - claim & deadline resolvers, which made whole picture incomplete.Fixes #8292