You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I genuinely don't know if moving this redirect on the server side is going to cut the extra 200ms seen in #8035. @lotas is there a way I can test it on a deployed instance? Using localhost doesn't enable me to test it.
I genuinely don't know if moving this redirect on the server side is going to cut the extra 200ms seen in #8035. @lotas is there a way I can test it on a deployed instance? Using localhost doesn't enable me to test it.
200ms depends on the region, as julien mentioned before for north america those are much lower, because storage is located in the same region as services
you can try setting TASKCLUSTER_ROOT_URL for index service to point to fxci (but you need proper credentials with correct permissions)
Discussed over Slack. Setting TASKCLUSTER_ROOT_URL locally won't likely show whether the fix works. In fact, I'm based in Europe and our Taskcluster instances are in North America. Hence, resolving the direct artifact URL on the server side isn't going to show any benefits because my server is in Europe anyway.
We agreed on merging this PR and testing on the dev instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue: Fixes #8035
Depends on #8283. This PR just adds one commit, the last one. The other ones come from #8283. Patch also tested manually:
Before
After