feat(w-m): Should worker terminate implementation#8282
Merged
Conversation
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
lotas
force-pushed
the
feat/should-worker-terminate
branch
from
077c8c6 to
9180e4d
Compare
lotas
commented
Feb 16, 2026
petemoore
previously approved these changes
Feb 17, 2026
Member
petemoore
left a comment
petemoore
left a comment
There was a problem hiding this comment.
Looks fine to me, but maybe Boris should review it too (maybe Heitor / Dustin might also be interested)
matt-boris
reviewed
Feb 17, 2026
Contributor
matt-boris
left a comment
matt-boris
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks! Just noted that we should probably mention the API that we're adding this implementation to.
This uses worker scanner loop to collect information about all running workers and at the end of the pass run the logic to dermine which workers to keep, and which should go This is stored in the worker.providerData, that api call is reading from. Decision can be updated with each worker scanner loop, so based on when worker makes the call, results might be different
lotas
force-pushed
the
feat/should-worker-terminate
branch
from
ad1027b to
b2a5e3a
Compare
worker_manager_workers_to_terminate with additional reason label shows how many workers were decided to be let go at the end of each scan
lotas
force-pushed
the
feat/should-worker-terminate
branch
from
b2a5e3a to
61fdbdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses worker scanner loop to collect information about all running workers and at the end of the pass run the logic to dermine which workers to keep, and which should go
This is stored in the worker.providerData, that api call is reading from.
Decision can be updated with each worker scanner loop, so based on when worker makes the call, results might be different
New
worker_manager_workers_to_terminatemetric captures this decision at the end of each scanner loopFixes #7147