feat(w-m): Provider workerGroup label for some metric#8248
Merged
Conversation
For worker deployers it might be useful to see breakdown by region/location of the workers to track costs more effectively.
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
matt-boris
approved these changes
Feb 5, 2026
| const stoppingCapacity = isStopping ? worker.capacity : 0; | ||
| const requestedCapacity = isRequested ? worker.capacity : 0; | ||
| const existingCapacity = isStopping || isQuarantined ? 0 : worker.capacity; | ||
| const quarantineCapacity = isQuarantined ? worker.capacity : 0; |
Contributor
There was a problem hiding this comment.
Looks like you fixed a bug here in this refactoring/clean up!
Previously, existingCapacity would be set to 0 then that value was added to quarantineCapacity, not properly counting the quarantineCapacity :) Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For worker deployers it might be useful to see breakdown by region/location of the workers to track costs more effectively.
Fixes #8247