queue: uri-encode artifact names in CDN urls#7234
Merged
lotas merged 1 commit intotaskcluster:mainfrom Sep 5, 2024
Merged
Conversation
jcristau
force-pushed
the
artifact-s3-encode
branch
5 times, most recently
from
52e2dcc to
aaba9b4
Compare
jcristau
changed the title
jcristau
force-pushed
the
artifact-s3-encode
branch
from
aaba9b4 to
923f7fc
Compare
jcristau
requested review from
lotas,
matt-boris and
petemoore
and removed request for
a team
lotas
reviewed
Sep 5, 2024
We can't use the artifact name as-is in the redirect, it can have characters that need to be encoded. Fixes taskcluster#7233
jcristau
force-pushed
the
artifact-s3-encode
branch
from
923f7fc to
4b7e1f7
Compare
lotas
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Bug/Issue: Fixes #7233