Parse application id as an int before comparing while fetching checks#5232
Merged
matt-boris merged 3 commits intotaskcluster:mainfrom Mar 1, 2022
Merged
Parse application id as an int before comparing while fetching checks#5232matt-boris merged 3 commits intotaskcluster:mainfrom
matt-boris merged 3 commits intotaskcluster:mainfrom
Conversation
Eijebong
requested review from
lotas and
petemoore
and removed request for
a team
lotas
reviewed
Mar 1, 2022
lotas
approved these changes
Mar 1, 2022
Turns out the helm configuration wants a string for `github.application_id` and the checks API returns an int. This wasn't caught because the config file doesn't enforce the type of `credentials.appId` and I did my testing with an int, not a string
lotas
approved these changes
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the helm configuration wants a string for
github.application_idand the checks API returns an int. This wasn'tcaught because the config file doesn't enforce the type of
credentials.appIdand I did my testing with an int, not a string