Update to docker-exec-websocket-* 3.0.0#5154
Conversation
jwhitlock
requested review from
lotas and
petemoore
and removed request for
a team
jwhitlock
force-pushed
the
docker-exec-websocket
branch
from
2884d1e to
6bc53fe
Compare
Update docker-exec-websocket-client and docker-exec-websocket-server. These should work under Node v14, and are required for Node v16. They fix an issue when the `docker exec` command is reading and writing data to the container. The test was using Buffer.compare(), which returns 0 when the buffers are equal, 1 when the first argument sorts first, and -1 when the second argument sorts first. This means the test was confirming the two buffers were _not_ equal, since 2015 or so.
jwhitlock
force-pushed
the
docker-exec-websocket
branch
from
6bc53fe to
2a7d877
Compare
|
The test was: .compare() is similar to The code was changed to use I've switched to use .equals(), which does what you'd expect. |
|
I've been staring at that test code for at least two weeks, and didn't notice I looked for other uses of Still, |
Aren't surprises fun? |
|
@jwhitlock If I'm reading correctly, this means, we might be able to bring the vnc code alive again for interactive graphical sessions? This would be brilliant, this was a killer feature, and it would be awesome to have it back working again. |
Maybe! The lack of two-way communication seems like it could have busted VNC, but I'm not familiar with the feature at all. It is possible it worked with a more traditional route like exposed ports. |
|
I doubt it's worth the effort to get something that complex working for docker-worker :) |
5 participants
Update
docker-exec-websocket-clientanddocker-exec-websocket-server. These should work under Node v14, and are required for Node v16. They fix an issue when thedocker execcommand is reading and writing datato the container.
This is part of PR #5095. The tests are failing under Node 16.13.2, and I'm curious if they also fail under the current Node 14.17.5.