Conversation
712dca4 to
dcc07bb
Compare
|
Rebased on main, force pushed. The commit "Check for uin32 size with ParseUnit" was suggested by a linter. When I went to run tests on the generic worker with There's one more linter issue that I wanted @petemoore's feedback on before merging. |
So looking at the warnings, they appear to be when strings are logged that are partly composed from data read in from the generic-worker config file. For example, in the generic-worker config file, the taskcluster root url property is set with the So I don't think any of these warnings are of particular concern, since a real user or task has no write access to the config file, and therefore cannot adjust values. If they could modify this file, we would have a much bigger problem, I believe. |
This fixes an issue where the generic worker failed to build on M1 MacBooks (arm64). Added notes for updating go and node.
dcc07bb to
16030a4
Compare
Update from Go 1.16.7 to 1.17.6. This is a major update which adds a new build constraints format. Details:
go fmton the files, generating the new build constraint commentGithub Bug/Issue: Fixes #5082
This was previously part of PR #5084, and incorporates feedback from reviews.