Remove dependency graceful#5037
Merged
petemoore merged 4 commits intotaskcluster:mainfrom Jan 12, 2022
Merged
Conversation
The method `Server.Shutdown` from the `net/http` standard library ought to handle server shutdown gracefully. https://pkg.go.dev/net/http#Server.Shutdown Closes taskcluster#4594
samihda
requested review from
leplatrem and
petemoore
and removed request for
a team
djmitche
approved these changes
Jan 8, 2022
Collaborator
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
Looks good to me, and works in my testing.
The docker-worker CI failures are unrelated to this PR, so don't worry about them :)
I'll defer to @petemoore for his review and merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
Server.Shutdownfrom thenet/httpstandard library oughtto handle server shutdown gracefully.
https://pkg.go.dev/net/http#Server.Shutdown
Bugzilla Bug: 1581546
Github Bug/Issue: Fixes #4594