Skip to content

Fix check for "no hooks defined" on /hooks#4948

Merged
jwhitlock merged 1 commit intotaskcluster:mainfrom
jwhitlock:ui-hooks-4946
Aug 6, 2021
Merged

Fix check for "no hooks defined" on /hooks#4948
jwhitlock merged 1 commit intotaskcluster:mainfrom
jwhitlock:ui-hooks-4946

Conversation

@jwhitlock
Copy link
Contributor

@jwhitlock jwhitlock commented Aug 6, 2021

Github Bug/Issue: Fixes #4946

Follow-on work from PR #4921, which switched to the built-in material-ui/treeview, but always detected that there were no hook defined.

Screenshot of /hooks page with this PR, against community-tc API:

fixed hooks

@jwhitlock jwhitlock requested a review from a team as a code owner August 6, 2021 17:15
@jwhitlock jwhitlock requested review from bsieber-mozilla and leplatrem and removed request for a team August 6, 2021 17:15
bsieber-mozilla
bsieber-mozilla approved these changes Aug 6, 2021
View reviewed changes
Copy link

@bsieber-mozilla bsieber-mozilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; doesn't appear related to what you added but oddly looks like there are some secrets being printed and logged (in what appeared to be a test)

@bsieber-mozilla
Copy link

bsieber-mozilla commented Aug 6, 2021 •
edited
Loading

(Looking at the failing tc check:)
https://community-tc.services.mozilla.com/tasks/EfEaT4CZSAGk_wLAeneZUw/runs/0/logs/public/logs/live.log

HEAD is now at 33346d38 Fix check for "no hooks defined" on /hooks
yarn install v1.22.10
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/googleapis/-/googleapis-73.0.0.tgz: unexpected end of file".
info If you think this is a bug, please open a bug report with the information provided in "/taskcluster/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[taskcluster 2021-08-06 17:20:51.586Z] === Task Finished ===
[taskcluster 2021-08-06 17:20:51.587Z] Unsuccessful task run with exit code: 1 completed in 92.425 seconds

taskcluster/yarn.lock

Lines 3295 to 3301 in b239801

googleapis@^73.0.0:
version "73.0.0"
resolved "https://registry.yarnpkg.com/googleapis/-/googleapis-73.0.0.tgz#8464ad2716d2400b6dab50fc1f47b374ed7919b8"
integrity sha512-bLLoHddONoEZCnhcTW603r7Y1fFqbFo0/3VdnzTNA4XQl+gVY3qycWmRSRrL15ts9Iwfg0rhTde5+OUuBFhi0g==
dependencies:
google-auth-library "^7.0.2"
googleapis-common "^5.0.2"

Hmm...

@jwhitlock jwhitlock mentioned this pull request Aug 6, 2021
Closed
@jwhitlock
Copy link
Contributor Author

jwhitlock commented Aug 6, 2021

The CodeQL scanner identified code not changed with this PR. I think they should be silenced, but I opened issue #4949 to track the effort.

The db-library failure looks like a temporary network failure. However, there doesn't appear to be a way to re-run the failing task. I've summarized my frustration on issue #4950, which may have duplicates.

@jwhitlock jwhitlock merged commit 36bb0e7 into taskcluster:main Aug 6, 2021
@jwhitlock jwhitlock deleted the ui-hooks-4946 branch August 6, 2021 19:23
@jwhitlock jwhitlock mentioned this pull request Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leplatrem leplatrem Awaiting requested review from leplatrem

1 more reviewer

@bsieber-mozilla bsieber-mozilla bsieber-mozilla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hook list view does not display hooks

2 participants

@jwhitlock @bsieber-mozilla