I would move this whole block into a separate component and file so when you pass the hook into this new component as a prop, its only going to re-render everything in that component if the prop has changed. Right now, if a user selects or expands (state change), this is going to be rendered even if the hookGroups hasn't changed.

can we have that as a follow up ticket? I would be adding a generic treeview component instead, this one is limited to depth 2 so it might be confusing, alternatively I could just move it as a functional component on top of the same file so we achieve short term rendering performance, what do you think?

Moving it to the top of the file is probably fine.

I think this situation, there's nothing the user can do to fix it so this may not be that helpful of an error message. :) I'd show a generic error message (you can see if there are already some in helper files) like 'Something went wrong - please file a bug at Taskcluster repo'.

Hmm, It is something that existed as behavior a prior my changes, I just accidentally ate it in one of commits, so this change is more restoration to status quo... also there is a bug to change the text to "No hooks are defined" if hooks view is empty.

Ok, I'd definitely switch to fetching directly from upstream (taskcluster repo) and rebasing (onto upstream/master) so you keep branch clean, rather than fetching from your fork/origin (if that's what you're doing) and merging (Btw, these just are my preferred terms - I always set remote upstream -> parent repo and origin -> my fork and only fetch from upstream). We can leave this for now, but fwiw, its definitely ok to change existing code if its not clear or not useful anymore :)

I think you're going to need to rebase and drop any of the merged commits that don't belong here and that might fix the failing test. Let me know when you've done that and I'll give one final look. We're nearly there :)

@cerkiewny Hi, just following up with this in case you missed my reply :)

I haven't missed it just had little time for TC last week and spent it trying to set up my k8s for it, I will probably follow it up today/tomorrow.

so, should I remove this? (It is btw in case of empty task cluster hooks not in case of errors) I fixed all the other things I think.

Well, wouldn't empty taskcluster hooks be an application error? It's not based on something the user did "wrong" so that message that is shown to the user doesn't seem very helpful in my opinion. If I saw that when trying to access menu items, I'd think that part of the app is broken.

But you can just leave it for now so we can get this landed. It seems the service-github task is failing. @petemoore do you know if this is an intermittent failure?

I thought it is meant for clean installation of taskcluster, if you dev init/ and start the backend, if there are no hooks defined yet, basically the message would show.