Skip to content

Drop support for VNC in interactive tasks.#4121

Merged
djmitche merged 3 commits intotaskcluster:mainfrom
djmitche:issue3542
Dec 16, 2020
Merged

Drop support for VNC in interactive tasks.#4121
djmitche merged 3 commits intotaskcluster:mainfrom
djmitche:issue3542

Conversation

@djmitche
Copy link
Collaborator

Github Bug/Issue: Fixes #3542, which has the context.

No existing worker implementation supports this.
This was never cleanly supported, and has not been functional at all for
a long time.  See taskcluster#3542 for details.
@djmitche djmitche requested a review from a team as a code owner December 16, 2020 20:49
@djmitche djmitche requested review from helfi92, imbstack and jwhitlock and removed request for a team and helfi92 December 16, 2020 20:49
This support has not worked for a long time; see taskcluster#3542 for details.
@djmitche
Copy link
Collaborator Author

I verified the UI still works for shell connections.

Copy link
Contributor

@imbstack imbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red, red, red

@djmitche
Copy link
Collaborator Author

I need to build a docker-worker image from this and test that out..

@djmitche
Copy link
Collaborator Author

My dev env isn't set up with the right DNS and public IPs and whatnot, but this generates a shell.html artifact as expected.

@djmitche
Copy link
Collaborator Author

OK, confirmed with a test worker pool in community. It works!

@djmitche djmitche merged commit 78ec825 into taskcluster:main Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for v2 shells/displays from UI

2 participants