Skip to content

Commit e19bb69

Browse files
matt-borismatt-boris
committed
Go patch update from 1.17.7 to 1.17.8
1 parent c1ac2e4 commit e19bb69

File tree

7 files changed

+58
-44
lines changed

7 files changed

+58
-44
lines changed

‎.go-version‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
go1.17.7
1+
go1.17.8

‎changelog/cs-p7I6OShKaU5znizhe4Q.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
audience: general
2+
level: patch
3+
---
4+
Go patch update from 1.17.7 to 1.17.8. Also upgrade golangci-lint from 1.39.0 to 1.44.2.

‎dev-docs/development-process.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ We use `yarn` to run most development commands, so [install that as well](https:
1818
### Go
1919

2020
<!-- the next line is automatically edited; do not change -->
21-
Go version go1.17.7 is required for some development tasks, in particular to run `yarn generate`.
21+
Go version go1.17.8 is required for some development tasks, in particular to run `yarn generate`.
2222
For new contributors not familiar with Go, it's probably safe to skip installing Go for now -- you will see a helpful error if and when it is needed.
2323
We recommend using https://github.com/moovweb/gvm to support installing multiple Go versions.
2424

‎dev-docs/node-and-go-upgrades.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ To update the node version:
2323

2424
To update the go version:
2525

26-
* Install the new go version, such as `gvm install go1.17.6`
27-
* Use the new go version, such as `gvm use go1.17.6`
26+
* Install the new go version, such as `gvm install go1.17.8`
27+
* Use the new go version, such as `gvm use go1.17.8`
2828
* Download modules with `go mod download`
2929
* Update `.go-version`
3030
* Run `yarn generate`. Some `go` errors may occur, for example on major version updates.

‎infrastructure/tooling/src/generate/generators/go-version.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,16 @@ exports.tasks = [{
3737
/Go version go[0-9.]+/,
3838
`Go version ${goVersion}`));
3939

40+
utils.status({ message: 'dev-docs/node-and-go-upgrades.md' });
41+
await modifyRepoFile('dev-docs/node-and-go-upgrades.md',
42+
contents => contents.replace(
43+
/install go[0-9.]+/,
44+
`install ${goVersion}`,
45+
).replace(
46+
/use go[0-9.]+/,
47+
`use ${goVersion}`,
48+
));
49+
4050
utils.status({ message: 'go.mod' });
4151
await modifyRepoFile('go.mod',
4252
contents => contents.replace(

‎workers/generic-worker/clean-builds.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ else
2828
#
2929
# DO NOT CHANGE HERE!
3030
####################################################################
31-
curl -o target/go.tar.gz -L https://storage.googleapis.com/golang/go1.17.7.darwin-amd64.tar.gz
31+
curl -o target/go.tar.gz -L https://storage.googleapis.com/golang/go1.17.8.darwin-amd64.tar.gz
3232
fi
3333

3434
tar -C "${GO_DOWNLOAD_DIR}" -xf target/go.tar.gz

‎workers/generic-worker/gw-decision-task/tasks.yml‎

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ Types:
66
Mounts:
77
# The next line is edited by infrastructure/tooling/src/generate/generators/go-version.js
88
# DO NOT CHANGE HERE!
9-
- 'go1.17.7'
9+
- 'go1.17.8'
1010
- 'git2.24.0.2'
1111
- 'jq1.6'
1212
- 'ci-creds'
13-
- 'golangci-lint-1.39.0'
13+
- 'golangci-lint-1.44.2'
1414
Command: BuildAndTest
1515
Features:
1616
taskclusterProxy: true
@@ -21,7 +21,7 @@ Types:
2121
- Name: 'public/build/generic-worker-${OS}-${ARCH}${EXTENSION}'
2222
# The next line is edited by infrastructure/tooling/src/generate/generators/go-version.js
2323
# DO NOT CHANGE HERE!
24-
Path: 'gopath1.17.7/bin/generic-worker${EXTENSION}'
24+
Path: 'gopath1.17.8/bin/generic-worker${EXTENSION}'
2525
Type: 'file'
2626
MaxRunTime: 3600
2727

@@ -38,7 +38,7 @@ Types:
3838
Mounts:
3939
# The next line is edited by infrastructure/tooling/src/generate/generators/go-version.js
4040
# DO NOT CHANGE HERE!
41-
- 'go1.17.7'
41+
- 'go1.17.8'
4242
Command: FormatSource
4343
MaxRunTime: 3600
4444

@@ -117,7 +117,7 @@ WorkerPools:
117117
# The next comment is edited by infrastructure/tooling/src/generate/generators/go-version.js
118118
# DO NOT CHANGE HERE!
119119

120-
# There is no arm release for go 1.17.7 on windows, but 386 release works
120+
# There is no arm release for go 1.17.8 on windows, but 386 release works
121121
# through emulation provided by the host OS.
122122
Arch: '386'
123123
proj-taskcluster/gw-ci-windows2012r2-amd64:
@@ -138,7 +138,7 @@ Commands:
138138
export CGO_ENABLED=0
139139
# The next line is edited by infrastructure/tooling/src/generate/generators/go-version.js
140140
# DO NOT CHANGE HERE!
141-
export GOROOT="$(pwd)/go1.17.7/go"
141+
export GOROOT="$(pwd)/go1.17.8/go"
142142
export PATH="${GOROOT}/bin:${PATH}"
143143
go version
144144
go env
@@ -191,8 +191,8 @@ Commands:
191191
192192
# The next two lines are edited by infrastructure/tooling/src/generate/generators/go-version.js
193193
# DO NOT CHANGE HERE!
194-
export GOROOT="$(pwd)/go1.17.7/go"
195-
export GOPATH="$(pwd)/gopath1.17.7"
194+
export GOROOT="$(pwd)/go1.17.8/go"
195+
export GOPATH="$(pwd)/gopath1.17.8"
196196
197197
export PATH="${GOPATH}/bin:${GOROOT}/bin:$(pwd)/bin:${PATH}"
198198
git --version
@@ -231,7 +231,7 @@ Commands:
231231
GW_TESTS_RUN_AS_CURRENT_USER=true GORACE=history_size=7 CGO_ENABLED=1 go test -tags "${ENGINE}" -timeout 45m -ldflags "-X github.com/taskcluster/taskcluster/v44/workers/generic-worker.revision=${GITHUB_SHA}" -v ${RACE} ${VET}
232232
fi
233233
GORACE=history_size=7 CGO_ENABLED=${CGO_ENABLED_TESTS} go test -tags "${ENGINE}" -timeout 45m -ldflags "-X github.com/taskcluster/taskcluster/v44/workers/generic-worker.revision=${GITHUB_SHA}" -v ${RACE} ${VET} ./...
234-
../../../golangci-lint/golangci-lint-1.39.0-*/golangci-lint run --build-tags "${ENGINE}" --timeout=15m
234+
../../../golangci-lint/golangci-lint-1.44.2-*/golangci-lint run --build-tags "${ENGINE}" --timeout=15m
235235
Windows:
236236
- |
237237
:: go test: -race and -msan are only supported on linux/amd64, freebsd/amd64, darwin/amd64 and windows/amd64
@@ -251,8 +251,8 @@ Commands:
251251

252252
# The next two lines are edited by infrastructure/tooling/src/generate/generators/go-version.js
253253
# DO NOT CHANGE HERE!
254-
- set GOROOT=%CD%\go1.17.7\go
255-
- set GOPATH=%CD%\gopath1.17.7
254+
- set GOROOT=%CD%\go1.17.8\go
255+
- set GOPATH=%CD%\gopath1.17.8
256256

257257
- |
258258
:: temporarily add C:\cygwin\bin to PATH - if this works out well, we should probably do it in system setup instead (i.e. in default system PATH of the image set)
@@ -303,10 +303,10 @@ Commands:
303303
:: assumption here is that if something inside the if fails, we'll get a non zero exit code
304304
:: i've also made it an if/else so that one of them has to run, as there should always be a
305305
:: linter
306-
if exist ..\..\..\golangci-lint\golangci-lint-1.39.0-windows-amd64 (
307-
..\..\..\golangci-lint\golangci-lint-1.39.0-windows-amd64\golangci-lint.exe run --build-tags "%ENGINE%" --timeout=15m
306+
if exist ..\..\..\golangci-lint\golangci-lint-1.44.2-windows-amd64 (
307+
..\..\..\golangci-lint\golangci-lint-1.44.2-windows-amd64\golangci-lint.exe run --build-tags "%ENGINE%" --timeout=15m
308308
) else (
309-
..\..\..\golangci-lint\golangci-lint-1.39.0-windows-386\golangci-lint.exe run --build-tags "%ENGINE%" --timeout=15m
309+
..\..\..\golangci-lint\golangci-lint-1.44.2-windows-386\golangci-lint.exe run --build-tags "%ENGINE%" --timeout=15m
310310
)
311311
312312
Mounts:
@@ -318,34 +318,34 @@ Mounts:
318318
#
319319
################################################################################
320320

321-
go1.17.7:
322-
directory: go1.17.7
321+
go1.17.8:
322+
directory: go1.17.8
323323
content:
324324
darwin:
325325
amd64:
326-
url: 'https://storage.googleapis.com/golang/go1.17.7.darwin-amd64.tar.gz'
327-
sha256: '7c3d9cc70ee592515d92a44385c0cba5503fd0a9950f78d76a4587916c67a84d'
326+
url: 'https://storage.googleapis.com/golang/go1.17.8.darwin-amd64.tar.gz'
327+
sha256: '345f530a6a4295a1bf0a25931c08bf31582ed83252580196bd643049dfef0563'
328328
format: tar.gz
329329
arm64:
330-
url: 'https://storage.googleapis.com/golang/go1.17.7.darwin-arm64.tar.gz'
331-
sha256: 'e141bd85577b875cc771cfcc18604989c861e93bbef377ba6c80d29e18f9a338'
330+
url: 'https://storage.googleapis.com/golang/go1.17.8.darwin-arm64.tar.gz'
331+
sha256: '2827fb5d62453b30f0644382e22ab9d287c7bca868c374a15145b29e272443b1'
332332
linux:
333333
armv6l:
334-
url: 'https://storage.googleapis.com/golang/go1.17.7.linux-armv6l.tar.gz'
335-
sha256: '874774f078b182fa21ffcb3878467eb5cb7e78bbffa6343ea5f0fbe47983433b'
334+
url: 'https://storage.googleapis.com/golang/go1.17.8.linux-armv6l.tar.gz'
335+
sha256: '3287ca2fe6819fa87af95182d5942bf4fa565aff8f145812c6c70c0466ce25ae'
336336
format: tar.gz
337337
amd64:
338-
url: 'https://storage.googleapis.com/golang/go1.17.7.linux-amd64.tar.gz'
339-
sha256: '02b111284bedbfa35a7e5b74a06082d18632eff824fd144312f6063943d49259'
338+
url: 'https://storage.googleapis.com/golang/go1.17.8.linux-amd64.tar.gz'
339+
sha256: '980e65a863377e69fd9b67df9d8395fd8e93858e7a24c9f55803421e453f4f99'
340340
format: tar.gz
341341
windows:
342342
386:
343-
url: 'https://storage.googleapis.com/golang/go1.17.7.windows-386.zip'
344-
sha256: '6be3a03549ee97de250a0dcc6658a5154e907540651a3fdec709e7b4df76038b'
343+
url: 'https://storage.googleapis.com/golang/go1.17.8.windows-386.zip'
344+
sha256: '2f3889642d706d7a4dd395ec4e08c00d962c845aa2998ca36a4493b0d0f071d9'
345345
format: zip
346346
amd64:
347-
url: 'https://storage.googleapis.com/golang/go1.17.7.windows-amd64.zip'
348-
sha256: '1b648165d62a2f5399f3c42c7e59de9f4aa457212c4ea763e1b650546fac72e2'
347+
url: 'https://storage.googleapis.com/golang/go1.17.8.windows-amd64.zip'
348+
sha256: '85ccf2608dca6ea9a46b6538c9e75e7cf2aebdf502379843b248e26b8bb110be'
349349
format: zip
350350
git2.24.0.2:
351351
directory: git
@@ -375,7 +375,7 @@ Mounts:
375375
windows:
376376
all:
377377
url: 'http://localhost/secrets/v1/secret/project/taskcluster/testing/generic-worker/ci-creds'
378-
golangci-lint-1.39.0:
378+
golangci-lint-1.44.2:
379379
# Note - we can't extract to directory '.' since after generic-worker
380380
# extracts the files as the root user (since generic-worker runs as root),
381381
# it then runs chown recursively against the target directory to make it
@@ -388,24 +388,24 @@ Mounts:
388388
content:
389389
darwin:
390390
amd64:
391-
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.39.0/golangci-lint-1.39.0-darwin-amd64.tar.gz'
392-
sha256: '7e9a47ab540aa3e8472fbf8120d28bed3b9d9cf625b955818e8bc69628d7187c'
391+
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.44.2/golangci-lint-1.44.2-darwin-amd64.tar.gz'
392+
sha256: 'ec6a8f0d6b2cb65efcc7ec138d91055b2ba51433093f97f8b76ce53ab5502971'
393393
format: tar.gz
394394
linux:
395395
armv6l:
396-
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.39.0/golangci-lint-1.39.0-linux-armv6.tar.gz'
397-
sha256: 'a7fa7ab2bfc99cbe5e5bcbf5684f5a997f920afbbe2f253d2feb1001d5e3c8b3'
396+
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.44.2/golangci-lint-1.44.2-linux-armv6.tar.gz'
397+
sha256: '6fc6bd3438de33c6a9a654d8e5bea7e12868fb80b29001ba7cf96d937b1e9a8e'
398398
format: tar.gz
399399
amd64:
400-
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.39.0/golangci-lint-1.39.0-linux-amd64.tar.gz'
401-
sha256: '3a73aa7468087caa62673c8adea99b4e4dff846dc72707222db85f8679b40cbf'
400+
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.44.2/golangci-lint-1.44.2-linux-amd64.tar.gz'
401+
sha256: '461e238f83e2b3deb48665be15d835fd3eab75a9a0138074ca2ad81315e0c3aa'
402402
format: tar.gz
403403
windows:
404404
386:
405-
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.39.0/golangci-lint-1.39.0-windows-386.zip'
406-
sha256: '494b66ba0e32c8ddf6c4f6b1d05729b110900f6017eda943057e43598c17d7a8'
405+
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.44.2/golangci-lint-1.44.2-windows-386.zip'
406+
sha256: 'fa1aff05fe4aac35fab2eb69890bc038df4d3cc4c0868f6310bea3be3ce9d110'
407407
format: zip
408408
amd64:
409-
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.39.0/golangci-lint-1.39.0-windows-amd64.zip'
410-
sha256: '52ec2e13a3cbb47147244dff8cfc35103563deb76e0459133058086fc35fb2c7'
409+
url: 'https://github.com/golangci/golangci-lint/releases/download/v1.44.2/golangci-lint-1.44.2-windows-amd64.zip'
410+
sha256: '8fc94fd292c4905332dcaee61dfe9104dc15713f49477c7494b63ee07a638a66'
411411
format: zip

0 commit comments

Comments
 (0)