Merge pull request #5232 from Eijebong/parseint-appid

matt-boris · web-flow · commit 0da5df609df9 · 2022-03-01T16:28:43.000-05:00
Parse application id as an int before comparing while fetching checks
diff --git a/changelog/Y0w6xTE9Qke2wg6iVGUu7Q.md b/changelog/Y0w6xTE9Qke2wg6iVGUu7Q.md
@@ -0,0 +1,4 @@
+audience: users
+level: patch
+---
+Fix the badge generation when using the badge API. It now works when deployed through helm too
diff --git a/services/github/config.yml b/services/github/config.yml
@@ -67,7 +67,7 @@ test:
 
   github:
     credentials:
-      appId: 66666
+      appId: '66666'
 
   webhook:
     secret: ['abc123', 'def456']
diff --git a/services/github/src/api.js b/services/github/src/api.js
@@ -172,7 +172,7 @@ async function findTCChecks(github, owner, repo, branch, configuration) {
     }
     throw e;
   }
-  return checks.filter(checkObject => checkObject.app.id === configuration.github.credentials.appId);
+  return checks.filter(checkObject => checkObject.app.id === parseInt(configuration.github.credentials.appId, 10));
 }
 
 /** API end-point for version v1/

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ async function findTCChecks(github, owner, repo, branch, configuration) {`
`172`	`172`	`}`
`173`	`173`	`throw e;`
`174`	`174`	`}`
`175`		`- return checks.filter(checkObject => checkObject.app.id === configuration.github.credentials.appId);`
	`175`	`+ return checks.filter(checkObject => checkObject.app.id === parseInt(configuration.github.credentials.appId, 10));`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`/** API end-point for version v1/`