Conversation
jonasfj
changed the title
|
@gregarndt, I think this is ready for review on Monday... If you don't have time for a full review, it would be awesome if you could at least build and deploy and AMI as test-worker or something.. .So I can play with the UI side of it... and see how bad the latency is... Maybe I do need to fix latency issues, I'm not sure yet. |
|
Last two commits can omitted... But I really hope that removing The idea was good, but websockets doesn't support redirects.. In future we'll add a JSON artifact with the urls for the sockets... at the moment the implication of this is that you can't build custom tools. |
|
I landed the tools patch without review, but please give it a quick rubberstamp review: |
There was a problem hiding this comment.
thanks for fixing this++
There was a problem hiding this comment.
I hope it works on Mac too...
Otherwise we'll have to dig up some old make magic :)
There was a problem hiding this comment.
I tested it, it works :)
Initial hack on noVNC support
3 participants
This is very hard to test automatically... I considered using phantomjs... but I'm not even sure that would work... and it quickly get very very complicated as we need to copy in noVNC sources.
I'm aware that it's not pretty to mix this with the interactive feature. But both of them needs the wrapper script that prevents exit while an interactive session is in progress. Also we don't want two options.