Merged
Conversation
petemoore
force-pushed
the
taskcluster-yml-simplification
branch
4 times, most recently
from
176be40 to
7c670ee
Compare
petemoore
force-pushed
the
taskcluster-yml-simplification
branch
from
7c670ee to
89b029c
Compare
jwhitlock
approved these changes
Feb 7, 2022
Contributor
jwhitlock
left a comment
jwhitlock
left a comment
There was a problem hiding this comment.
Thank @petemoore!
It looks like my last round of changes stopped the test output from appearing in the Taskcluster logs. The build step appears to be working, installing the NPM packages, so I'm not sure what changed. In any case, it doesn't appear to be added by this PR, so let's merge and fix in a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should be enough - let's wait for the CI to confirm before landing though! :-)
The previous path works for now (
/$${USER}/...) but would break once the worker is fixed to havetasksDirset to/home.The new version is independent of the
tasksDirsetting on the worker, since the path is relative to the task directory.