Repository navigation
Commit faaa78d
authored
fix(responses): reject malformed selectors at the authorization gate (lidge-jun#2501)
Refusing to rewrite a malformed selector was not enough. When its name is
already the flattened wire name — {type:"function", namespace:1,
name:"collaboration__safe"} — returning it unchanged leaves an exact
match against the alias map, so the alias arms anyway and an upstream
call is restored into the namespace. Both selector shapes reach it.
The check belongs at the authorization gate, not only in the rewriter: a
malformed namespace makes the whole selector untrustworthy regardless of
which name it carries. The unqualified shape is untouched, since an
absent namespace is a deliberate, legitimate selector.
Also states the POSIX permission precondition in the troubleshooting
page, which described only the content half of the skip rule.
Tests cover both malformed-with-wire-name shapes and keep a positive
control on the unqualified selector so the fix cannot pass by being
deny-all. 186 pass across namespace-tool-compat, responses-parser,
openai-responses-passthrough, and the write-amplification suite.
tsc --noEmit clean.1 parent 43227ac commit faaa78d
3 files changed
Lines changed: 52 additions & 9 deletions
File tree
- docs-site/src/content/docs/troubleshooting
- src/responses
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
220 | 231 | | |
221 | 232 | | |
222 | 233 | | |
223 | 234 | | |
224 | 235 | | |
225 | 236 | | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
232 | 241 | | |
233 | 242 | | |
234 | 243 | | |
| |||
276 | 285 | | |
277 | 286 | | |
278 | 287 | | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
279 | 291 | | |
280 | 292 | | |
281 | 293 | | |
| |||
290 | 302 | | |
291 | 303 | | |
292 | 304 | | |
| 305 | + | |
293 | 306 | | |
294 | 307 | | |
295 | 308 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
302 | 331 | | |
303 | 332 | | |
304 | 333 | | |
| |||
0 commit comments