Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Work around poor GHC performance on Diff and Merge#77

Merged
dwincort merged 1 commit intomasterfrom
unknown repository
Jun 5, 2021
Merged

Work around poor GHC performance on Diff and Merge#77
dwincort merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 3, 2021

The problem is the same as in #71.

I also have tried to fix Inject and LacksR but haven't found tests cases with bad performance.

Copy link
Collaborator

@dwincort dwincort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really sorry this took a month for me to get to, but thank you for contributing! If Injet and LacksR aren't a problem (yet), then let's just not deal with them -- we can always modify them in the future if/when the need arises.

@dwincort dwincort merged commit 1f07d44 into target:master Jun 5, 2021
@ghost ghost deleted the patch-operators-with-ifte branch June 7, 2021 08:01
@ghost
Copy link
Author

ghost commented Jun 7, 2021

No problem! Thanks!

Would be cool to get it on Hackage :)

@shinzui
Copy link

shinzui commented Sep 1, 2021

Is it possible to publish, please 🙏?

@dwincort
Copy link
Collaborator

dwincort commented Sep 9, 2021

@AK3N, Wow, I totally lost track of time this summer. Thanks for the reminder @shinzui -- I just pushed the release to hackage (https://hackage.haskell.org/package/row-types-1.0.1.1).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants