Repository navigation
test(cli): await attached input readiness in held-frame regression - #1129
Conversation
…frame witness Reaching the held first content write does not prove the attached UI has subscribed to its terminal input; under Bun on CI it had not, and the hard reader assertion saw 0. The regression now waits for that subscription through the existing bounded `awaited` helper while the write stays held, then keeps every assertion it had. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Independent review closeout — Codex Astra ( The original Planner independently passed. Prior feature review and its nonblocking performance-method qualification remain unchanged. No product changes or benchmark repeat. Required CI and the main-repair gate remain delivery requirements. |
PR #1129: test(cli): await attached input readiness in held-frame regression1 files, +4 / -1 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static Analysis✅ Oxlint found no issues. Correctness✅ Small PR — correctness review skipped. |
Why
Main CI fails in the attached first-frame regression introduced by #1124. Reaching the held first content write does not prove that the separate terminal input reader has subscribed; Bun 1.4.0 observed zero readers in both CI attempts.
Closes #1128. Repairs the test failure tracked by #1126.
What changes
Wait for the actual input subscription through the existing bounded
awaitedhelper before asserting the exact reader count and feeding input. The first content write stays held. Every original assertion remains: blank screen, one reader, detach without another key, zero prompts, one reset, no remaining readers/listeners and subsequent child usability.Only
packages/cli/tests/repl-headless-attach.test.tschanges (+4/-1). Product behavior, timeouts, runtime selection, dependencies and generated files are unchanged.Validation
Signed feedback commit
25576418d2ffdd6d2908273aec6cf00528de4019, based on merged main80959039dc0fbca2cc4c047941a5e23cc6ed5178:Local Bun is 1.3.14, while the CI failure is on Bun 1.4.0. Local baseline passed; the controlled schedule reproduces the missing precondition without claiming a natural local 1.4.0 reproduction. No benchmark repeats for a test-only change.
Scope confirmation