Repository navigation
🐛 Check portable file permissions before routing - #1122
Conversation
Carry the reviewed two-file permission correction forward after #1121 merged.
PR #1122: 🐛 Check portable file permissions before routing2 files, +93 / -18 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static AnalysisOxlint: 2 diagnostics across 1 file (1 rule) no-shadow (2): packages/cli/src/repl/workspace-mount-installation.ts CorrectnessFILE: packages/cli/src/repl/workspace-mount-installation.ts FILE: packages/cli/src/repl/workspace-mount-installation.ts No other extraneous code patterns detected. |
taras
left a comment
taras
left a comment
There was a problem hiding this comment.
Independent review: PASS at 8aa69addd53a427da8a2e0f36bfcc0f9c13263d2 (Codex Astra, medium; same independent conversation used for #1121).
The reviewer confirms its sole prior blocker is resolved: portable/manual live requests meet read/write and applicable absolute permissions before canonicalization, including when Sidekick limits are absent. Acknowledged results still restore before live checks, terminal checks still apply to transformed requests, and allowed manual work outside the project remains supported. The focused regression distinguishes the original failure from corrected behavior. No blocking findings remain.
The two-file correction passed the original affected Architect review. Its pre-integration tested tree and this signed follow-up tree are identical; the old and new two-file patches are byte-identical. Original A1–A12 conclusions carry forward. Required CI remains a separate merge gate.
taras
left a comment
taras
left a comment
There was a problem hiding this comment.
Independent integration closeout: PASS at 9c0e27ba4f82d6dda6074686439c4956be89a6c5 (same Codex Astra reviewer, medium).
The normal base update incorporates green main 7da1eb6c after GitHub refused an out-of-date branch. The two-file permission fix is byte-identical against the new base. The reviewer traced the affected integration and confirms the adapter preparation/import changes do not alter Files admission, acknowledged replay ordering or final effective-request checks. Relevant runtime dependencies and the fix's callers are unchanged; prior A1–A12 conclusions carry forward. No findings remain.
Fresh CI2451 is required for this exact integration head. Prior green CI2450 is retained only as evidence for the previous head. The integration commit is verified by GitHub, and tracked files stayed clean through required dependency preparation and review.
Portable/manual REPL entries now check live filesystem permissions before canonicalizing a target for retained-file routing. Previously an absolute
<Dir>could resolve its parent before the write/absolute permission refusal. Acknowledged results still restore first, transformed requests retain terminal checks, and permitted manual work outside the project remains supported.This is the remaining two-file correction after #1121 merged. Its focused Deno, Node 22 and Bun 1.4 regressions and original affected Architect review pass. The same independent Astra reviewer passed exact integration head
9c0e27ba4f82d6dda6074686439c4956be89a6c5, confirming the finding remains resolved after the normal update to current main. Fix bytes are unchanged, and GitHub verified the integration commit.Required CI2451 passed on the exact reviewed integration head. Normal protected auto-merge completed at
2f0ddfd0c7c8352d1d61b0100f85ff541623356e; no bypass was used.Follow-up to #1113 and #1121.