Repository navigation
🗂️ Preserve Dir placement through Content - #1114
Conversation
PR #1114: 🗂️ Preserve Dir placement through Content6 files, +337 / -71 Scope🟡 408 lines changed. PRs under 400 receive more thorough review. StructuralOxlint structural signals:
SlopOxlint slop signals:
Static AnalysisOxlint: 72 diagnostics across 1 file (13 rules) no-useless-default-assignment (35): packages/core/src/expand.ts Correctnesspackages/core/src/expand.ts: no-unused-vars: Dead constructs — unused variables in generator functions. QUESTION: Are these variables required for future extension or redundant? |
taras
left a comment
taras
left a comment
There was a problem hiding this comment.
Independent review at 1d68d211cbdd54b486505ef0c6b3b28bd71268b4: PASS (Codex Astra, medium).
A1–A5 were checked against the original plan, exact committed diff, affected callers and focused evidence. No substantive correctness, minimalism or consequential performance findings. No source changes or broad test reruns were made.
Fable returned an actual quota refusal; its joined failed attempt is retained. Astra supplies the repository-required replacement verdict, rather than an additional review stage. Original Planner acceptance also passes. Required CI remains a separate merge gate.
Markdown wrappers that place
<Content />inside<Dir>currently lose the selected working directory. Projected commands and relative File reads now use the directory at each projection point, while caller bindings and content-scope ownership remain intact. Leaving the wrapper restores the enclosing directory.The correction transfers only contextual cwd and the existing private filesystem placement through the structural projection boundary. It adds no public API, dependency or persistence change. The MDX specification describes the corrected behavior.
Validation at signed commit
1d68d211cbdd54b486505ef0c6b3b28bd71268b4:First failure logs and tested-candidate correspondence are retained. The separate #1113 launch-cwd/access work is outside this PR.
Closes #985.