Repository navigation
Make REPL syntax discovery reflect entry availability - #1065
Conversation
PR #1065: Make REPL syntax discovery reflect entry availability7 files, +386 / -50 Scope🟡 436 lines changed. PRs under 400 receive more thorough review. StructuralOxlint structural signals:
Slop✅ Slop indicators look low. Static AnalysisOxlint: 7 diagnostics across 2 files (6 rules) no-unsafe-type-assertion (2): packages/cli/tests/fixtures/repl/issue-883/sidekick-harness.ts CorrectnessFILE: packages/cli/tests/fixtures/repl/issue-883/sidekick-harness.ts FILE: packages/cli/src/repl-profile.ts FILE: packages/cli/tests/fixtures/repl/issue-883/sidekick-harness.ts FILE: packages/cli/tests/fixtures/repl/issue-883/sidekick-harness.ts |
taras
left a comment
taras
left a comment
There was a problem hiding this comment.
Correctness/minimalism review: PASS for 5317150. No actionable findings.
The ordinary REPL catalog now uses its actual registry, finalized includes, and entry installations. Named documentation adds test-component references while retaining ordinary symbols for identity-based availability. Ordinary overrides remain authoritative, unknown names refuse the whole lookup, and descriptive lookup does not install test execution behavior into ordinary entries. The change reuses the existing inspection and reference APIs without adding a public API.
Evidence reviewed: the published seven-file diff, selection/registration/reference implementations and callers, repository contracts, and supplied focused results. At this head, the REPL journey and CLI syntax suites passed (20 tests, 92 steps), with Deno and Node typechecks. Earlier feature-revision evidence separately covers 48 tests/197 steps and the bounded admission, denied-write, and REPL.Test experiment; those results are not attributed to this head. I did not repeat tests or wait for CI.
Performance: measurements are not applicable. The changed construction is reached on explicit documentation requests; rendering, input, ordinary dispatch, and cleanup paths are unchanged. No concrete performance-sensitive affected caller was found. No benchmarks or profilers were run, and no timing or memory claim is made.
Main health and required CI checks remain merge gates.
REPL syntax discovery describes the components available to ordinary entries. Named Assert and AssertEquals references explain their Markdown-test context and provide a complete REPL.Test example; ordinary entries retain their existing admission rules.
Discovery uses finalized entry installations and current session components. Same-named session components retain precedence, selected Plugins agree with execution, and permission refusal remains distinct from missing resolution. CLI run-profile assertions remain available. The integration preserves both this feature and main’s nested Output journeys.
Validation: the original feature feedback at f49c528 passed 48 focused tests / 197 steps, Deno source checks, Node typechecking, changed-file lint and formatting. Production-boundary journeys cover ordinary execution, named test references, unknown names, denied file writes, component refresh and Plugin selection. The documented test example executes with one attempt and zero replacement retries. The integrated head 5317150 passed 20 affected tests / 92 steps and both typechecks; the original Planner accepted the feature and the integration at their exact heads.
Independent Astra review passes 5317150 with no actionable correctness or minimalism findings. Measurements are not applicable to this on-demand documentation change; no timing or memory assurance is claimed. Required CI is green at the same reviewed head.
Fixes #1053.