Skip to content

Focus independent review on correctness, minimalism and performance - #1049

Merged
taras merged 4 commits into
mainfrom
codex/review-after-main-green
Nov 1, 2026
Merged

taras merged 4 commits into
mainfrom
codex/review-after-main-green

Conversation

@taras

@taras taras commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Why

Independent review should find defects, unnecessary complexity and consequential performance costs. Identity checks and review bookkeeping belong to the workflow or coordinator rather than another model investigation.

What changes

Adds a shared .agents/reviewer.md for existing Fable and Codex Astra review assignments, with three priorities:

  • Correctness: trace real callers and relevant failure paths; judge whether evidence demonstrates the accepted behavior.
  • Minimalism: identify code, APIs, state and tests that can be removed while preserving that behavior. Trace existing APIs and supported composition before accepting new surface; necessary extensions need a concrete gap and a real consumer.
  • Performance: when UI interactions or performance-sensitive paths are affected, inspect responsiveness, repeated work, allocations, I/O, retention and scaling with content/history. Reuse measurements and run targeted comparisons where consequential costs are uncertain; avoid speculative optimization and unrelated benchmarks.

The repository rules and workflow guide direct independent reviewers to this role. Mechanical validation, provider selection, receipts and bookkeeping stay with their existing owners. The guide adds no workflow phase or review stage.

Fable reviews start when the exact feedback commit and focused evidence are ready, without waiting for CI on main or the reviewed branch. When Fable is unavailable, including exhausted Claude quota, use an independent Codex Astra (gpt-6-astra) reviewer under the same scope, effort policy and correction limits. Preserve prior findings and reconcile in-flight calls before fallback.

Main health and required CI remain merge gates; a review pass waives neither.

How to verify it

  • git diff --check passes.
  • Verified 16 local documentation links in the changed documents.
  • Three documentation files change; Planner and Architect guides retain their existing focused-review rules.
  • Documentation-only change; no runtime tests run.

Scope confirmation

  • Every changed file supports the focused independent-review role and its scheduling/fallback rules.
  • Unrelated cleanup and formatting changes are excluded.
  • No generated artifacts or dependencies change.
  • The description matches the final diff and verification.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

PR #1049: Define independent review with API reuse checks and Astra fallback

3 files, +95 / -0

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

@taras taras changed the title Require green main before starting code reviews Start Fable reviews without waiting for CI and add Astra fallback Nov 1, 2026
@taras taras changed the title Start Fable reviews without waiting for CI and add Astra fallback Define independent review with API reuse checks and Astra fallback Nov 1, 2026
@taras taras changed the title Define independent review with API reuse checks and Astra fallback Focus independent review on correctness, minimalism and performance Nov 1, 2026
@taras
taras enabled auto-merge (squash) November 1, 2026 03:50
@taras
taras disabled auto-merge November 1, 2026 04:16
@taras
taras merged commit aae9572 into main Nov 1, 2026
58 checks passed
@taras
taras deleted the codex/review-after-main-green branch November 1, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant