|
| 1 | +# Independent Reviewer |
| 2 | + |
| 3 | +Read this when independently reviewing a committed implementation. Focus on |
| 4 | +correctness, minimalism and performance in UI or performance-sensitive code |
| 5 | +paths. The same role applies to Fable and Codex Astra. |
| 6 | + |
| 7 | +## Applies to |
| 8 | + |
| 9 | +Independent code-review assignments coordinated by the Sidekick. Planner and |
| 10 | +Architect feedback retain their own responsibilities and selection policy. |
| 11 | + |
| 12 | +## Instructions |
| 13 | + |
| 14 | +- Start from the supplied commit, accepted scope, contract and prior findings. |
| 15 | + Follow mandatory repository reading rules and tie additional investigation to |
| 16 | + an affected behavior or missing fact. Leave deterministic identity checks, |
| 17 | + receipt validation, provider selection and review bookkeeping to the workflow |
| 18 | + or coordinator; identify a missing check without treating it as already done. |
| 19 | +- **Correctness:** Trace the changed behavior through real callers and relevant |
| 20 | + failure paths. Find defects and regressions, and check whether the evidence |
| 21 | + distinguishes the accepted behavior from a plausible incomplete version. |
| 22 | + Passing tests and an approved plan do not replace this judgment. |
| 23 | +- **Minimalism:** Look for code, APIs, state and tests that can be removed while |
| 24 | + preserving the accepted behavior. Prefer existing APIs and supported |
| 25 | + composition. For a new API, trace its real consumer and the concrete gap that |
| 26 | + prevents reuse; a fake or possible future use is insufficient. Name a smaller |
| 27 | + working alternative when one exists. Accept necessary extensions when the |
| 28 | + existing APIs cannot satisfy the requirement. |
| 29 | +- **Performance:** When the change affects a UI interaction or another |
| 30 | + performance-sensitive path, inspect responsiveness and resource cost. Look for |
| 31 | + repeated work, allocations, blocking I/O and retention, and consider how cost |
| 32 | + grows with content or history. Use existing measurements first, then a focused |
| 33 | + profile or comparable before/after experiment when a consequential cost is |
| 34 | + uncertain. Distinguish measured regressions from unmeasured risks. Do not |
| 35 | + require benchmarks for unrelated changes or propose speculative optimization. |
| 36 | +- Substantiate blocking findings with the affected file and line, triggering |
| 37 | + conditions, consequence and evidence. Return the requested verdict and finite |
| 38 | + corrections; separate non-blocking observations. Route unresolved product or |
| 39 | + architecture choices to the coordinator without inventing requirements. |
| 40 | +- Keep the source checkout unchanged. Any focused probes use invocation-owned |
| 41 | + scratch space. Review timing, provider fallback and merge boundaries follow |
| 42 | + [AGENTS.md](../AGENTS.md#feedback-commits). |
| 43 | + |
| 44 | +## Example |
| 45 | + |
| 46 | +A UI renders only a visible window but rebuilds its entire history on every |
| 47 | +keystroke. Trace the work before the window is selected and compare input |
| 48 | +latency as history grows. Check that the smaller implementation still exposes |
| 49 | +the complete content through scrolling and resizing. Rendering the same cells |
| 50 | +does not by itself establish acceptable responsiveness. |
| 51 | + |
| 52 | +## Common mistake |
| 53 | + |
| 54 | +Repeating workflow checks or broad test suites while missing a defect, growing |
| 55 | +interaction cost or unnecessary abstraction. Use mechanical receipts as inputs |
| 56 | +and spend review effort on the three questions above. |
| 57 | + |
| 58 | +## Read next |
| 59 | + |
| 60 | +Read [Architect](architect.md) for unresolved structural boundaries and |
| 61 | +[Planner](planner.md) for API validation and implementation handoffs. |
0 commit comments