Repository navigation
Commit dcf4ea5
committed
🧷 Ask a publication which wait it stands behind, and whether it carried a value
Two ways a snapshot still reached a canonical identity it had not earned.
A request describes its wait twice, in `name` and in `suspensionId`, and the
structural pairing only compared the first. A pair agreeing about the name and
disagreeing about the identity names two waits, and neither of them is one the
other could have ended. Both fields are now compared, and asked of every
publication rather than only of one some retained row points at — inherited
history legitimately arrives as a request and its publication with no row
behind them, which is exactly where nothing else was looking.
A successful publication was read through `result.value ?? null`, so a result
carrying no value at all read as a publication of `null`. A wait that ended
with nothing and a wait whose retained answer is null are different histories,
and one was standing in for the other. The member is now asked for by name, and
only once it is there is the value compared.
Both regressions are writer-path, because neither can be made by damaging a
sealed file — a sealed file is one this build already accepted. They are
snapshots offered to `writeXmdArtifact()`, which has to refuse them before a
container exists, and the test asserts nothing is left at the destination.
At the previous commit each of them is written and given an identity. Removing
either check alone puts that back.
Refs #6021 parent 046176e commit dcf4ea5
2 files changed
Lines changed: 113 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1479 | 1479 | | |
1480 | 1480 | | |
1481 | 1481 | | |
1482 | | - | |
1483 | | - | |
1484 | | - | |
1485 | | - | |
1486 | | - | |
| 1482 | + | |
1487 | 1483 | | |
1488 | 1484 | | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
1489 | 1493 | | |
1490 | 1494 | | |
1491 | 1495 | | |
| |||
1544 | 1548 | | |
1545 | 1549 | | |
1546 | 1550 | | |
1547 | | - | |
| 1551 | + | |
| 1552 | + | |
1548 | 1553 | | |
1549 | 1554 | | |
1550 | | - | |
1551 | | - | |
1552 | | - | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
1553 | 1566 | | |
1554 | 1567 | | |
1555 | 1568 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
133 | 136 | | |
134 | 137 | | |
135 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
136 | 192 | | |
137 | 193 | | |
138 | 194 | | |
| |||
865 | 921 | | |
866 | 922 | | |
867 | 923 | | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
868 | 958 | | |
869 | 959 | | |
870 | 960 | | |
| |||
0 commit comments