Repository navigation
Commit d437949
committed
🔀 Let one invocation create the pull request and then update it
#301's architecture amendment settles the composition the revision loop was
missing. An expression prop that evaluates to `undefined` is omitted before prop
validation and before the durable JSON boundary, so a document can seed a
binding with an empty object and say the same thing on every iteration.
The loop does that now. `let pullRequest = {}` is declared once, before the
loop; the single `<PullRequest number={pullRequest.number} …>` inside it reads
`undefined` on the first pass, so `number` is omitted and the unnumbered
create-or-adopt contract applies; the result replaces the seed through ordinary
`as` binding, and every later pass carries the retained positive number into the
numbered update contract for that exact pull request. What made this necessary
is unchanged: a revision commits again, so an unnumbered second request would
find a pull request holding a different head and refuse it as a conflict.
Two of the three pieces already work, and the probe checks both rather than
assuming them — a member read on the seed yields `undefined` in an expression
prop without failing, and an `as=` binding shadows the eval-declared name for
later props. The third does not: the engine refuses an undefined prop today
rather than omitting it. So the documents carry the omission as #301's, unbuilt,
and the probe fails if that ever silently becomes true without the prose
catching up.
The amendment is general, and the reference state says so: required props still
fail as missing, `null` stays an explicit value, and an unbound name still
fails. None of it is a `PullRequest` special case, and no engine code changes
here — Planning owes that proof before implementation is handed off.1 parent 99e69a2 commit d437949
3 files changed
Lines changed: 48 additions & 28 deletions
File tree
- specs
- workflows/adversarial-implementation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
994 | 994 | | |
995 | 995 | | |
996 | 996 | | |
997 | | - | |
998 | | - | |
999 | | - | |
1000 | | - | |
1001 | | - | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
1002 | 1005 | | |
1003 | 1006 | | |
1004 | 1007 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
132 | 136 | | |
133 | 137 | | |
134 | 138 | | |
| |||
205 | 209 | | |
206 | 210 | | |
207 | 211 | | |
208 | | - | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
209 | 218 | | |
210 | 219 | | |
211 | 220 | | |
| |||
474 | 483 | | |
475 | 484 | | |
476 | 485 | | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
498 | 513 | | |
499 | 514 | | |
500 | 515 | | |
| |||
615 | 630 | | |
616 | 631 | | |
617 | 632 | | |
618 | | - | |
| 633 | + | |
| 634 | + | |
619 | 635 | | |
620 | 636 | | |
621 | 637 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
| 453 | + | |
453 | 454 | | |
454 | 455 | | |
455 | 456 | | |
| |||
0 commit comments