Repository navigation
Commit ccd2de3
committed
🔒 Hold the octal escape to Git's grammar, which stops at 3
Git's `unquote_c_style()` cases an octal escape's leading digit as `0`-`3` and
nothing else, because an escape names one byte and `\400` is already 256. So
`\4` through `\7` are escapes Git does not have: the quoting fails and
`parse_alt_odb_entry()` reads the whole entry as ordinary literal text.
The containment scanner accepted any leading octal digit and then assembled the
value through a typed array, so `\457` became 303 truncated to 47 — a `/`. It
saw a path separator where Git sees no escape at all, and one alternates entry
then named two different object directories: extra segments the invented
separator created, which a decoy inside the authenticated database answers for,
and the literal fallback Git actually traverses.
The grammar now stops at 3, and the byte a valid escape names is range-checked
on the way in rather than assumed, so no value can reach a typed array and come
back out as a different character. Everything Git rejects stays on the same
literal fallback Git uses, and an entry whose exact path still cannot be named
fails closed. Quoted entries, the transitive chain, symlink escapes, lazy
completed replay and the withheld failure text are unchanged.
The regression plants both readings of one entry: the decoy chain the
truncating reading resolves, and a database outside the materialization that
only Git's literal fallback reaches. Ordinary Git in the same export resolves a
commit this run never held through it. Widening the leading digit back to `0-7`
fails that test alone, with the other twenty-one steps in the suite still
passing.
Refs #370.1 parent 3f889e1 commit ccd2de3
2 files changed
Lines changed: 148 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
153 | 169 | | |
154 | 170 | | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
155 | 183 | | |
156 | 184 | | |
157 | 185 | | |
| |||
181 | 209 | | |
182 | 210 | | |
183 | 211 | | |
184 | | - | |
| 212 | + | |
| 213 | + | |
185 | 214 | | |
186 | 215 | | |
187 | 216 | | |
| |||
224 | 253 | | |
225 | 254 | | |
226 | 255 | | |
227 | | - | |
| 256 | + | |
228 | 257 | | |
229 | 258 | | |
230 | 259 | | |
231 | 260 | | |
232 | 261 | | |
233 | 262 | | |
234 | 263 | | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
235 | 268 | | |
236 | | - | |
| 269 | + | |
237 | 270 | | |
238 | 271 | | |
239 | 272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1079 | 1079 | | |
1080 | 1080 | | |
1081 | 1081 | | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
1082 | 1194 | | |
1083 | 1195 | | |
1084 | 1196 | | |
| |||
0 commit comments