Repository navigation
Commit cbd3009
authored
🐛 Let the workflow host answer its own <Elicit> through the CLI (#609)
* 🐛 Let the workflow host answer its own <Elicit> through the CLI (#607)
Whether an execution activates the testing stack and whether this host owns
elicitation are two decisions, and the CLI made them as one: every non-testing
document got the Web provider. A workflow start is a non-testing document, so
the provider landed in the nested document scope inside the host's attachment —
nearer, at the same `{ at: "min" }`, and therefore first. A workflow reaching
`<Elicit>` opened a loopback form and waited for a reader who is not coming
instead of committing a `suspension_request` and settling `suspended`.
`DocumentMode` now carries a required `webElicitation`, and each trusted profile
states it: `xmd run` and the nested `host="run"` profile enable it, `xmd test`
and `xmd workflow` do not. Required rather than defaulted, so a profile added
later cannot inherit the browser form by omission. `installWebComponents()`
stays unconditional — an authored `<WebForm>` under a workflow still asks
through its own component.
The regression launches the real Deno-source CLI, because no in-process caller
builds the assembly that was broken: `runWorkflow()` and `executeInstalled()`
both skip it. Before the fix the case is abandoned at its deadline with
`http://127.0.0.1:<port>/f/…` on the captured channel.
* ♻️ Compose the run profile's elicitation provider instead of flagging it (#607)
Review of 8b380b9: a trusted host profile must install Web elicitation
directly, through lexical composition, rather than by handing the shared
assembly a property to interpret.
`DocumentMode.webElicitation` is gone, and `installDocumentComponents()` no
longer installs an elicitation provider for any command — it neither receives
nor reads a profile. `installWebComponents()` stays unconditional, so
`<WebForm>` remains registered everywhere.
Instead, each profile composes what it owns. `xmd run` installs
`installWebElicitation()` in the scope it assembles around its own document, and
the nested `host="run"` profile installs it in the isolated scope the harness
gives a child — restated there rather than inherited, because a child of
`xmd test` is still the run profile and its command composes none. `xmd test`
and `xmd workflow` compose no elicitation provider at all, so the workflow
attachment's suspending provider stays the only one a workflow document can
reach.
The behavior is the one 8b380b9 established and the four-profile table is
unchanged; what moves is where the decision lives. Absence is now how a profile
says it does not own the question, so there is no flag to read and no default to
inherit.
The subprocess regression is unchanged, and still fails on the defect: with
`installWebElicitation()` moved back into the shared assembly, the case is
abandoned at its deadline with the loopback form URL in its captured output.
---------
Co-authored-by: Taras Mankovski <[email protected]>1 parent 2f06e79 commit cbd3009
3 files changed
Lines changed: 177 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
628 | 628 | | |
629 | 629 | | |
630 | 630 | | |
631 | | - | |
632 | | - | |
633 | | - | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
638 | | - | |
639 | | - | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
640 | 643 | | |
641 | 644 | | |
642 | 645 | | |
| |||
1692 | 1695 | | |
1693 | 1696 | | |
1694 | 1697 | | |
1695 | | - | |
1696 | | - | |
1697 | | - | |
1698 | | - | |
1699 | | - | |
1700 | | - | |
1701 | | - | |
1702 | | - | |
1703 | | - | |
1704 | | - | |
1705 | | - | |
1706 | | - | |
1707 | | - | |
1708 | | - | |
1709 | | - | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
1710 | 1722 | | |
1711 | | - | |
1712 | | - | |
1713 | | - | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
1714 | 1726 | | |
1715 | 1727 | | |
1716 | 1728 | | |
| |||
1832 | 1844 | | |
1833 | 1845 | | |
1834 | 1846 | | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
1835 | 1851 | | |
1836 | 1852 | | |
1837 | 1853 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| |||
94 | 96 | | |
95 | 97 | | |
96 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
97 | 105 | | |
98 | 106 | | |
99 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| |||
1462 | 1468 | | |
1463 | 1469 | | |
1464 | 1470 | | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
0 commit comments