Repository navigation
Commit ba30306
committed
🐛 Ship packaged documents that sit in subdirectories (#83)
`packagedDocuments()` lists `src/documents/` recursively and every entry it
returns becomes a `copyFile`. A recursive listing names the directories as well
as the files inside them, so the first package whose documents are not flat
fails the whole npm build with `EINVAL` — "the source path is neither a regular
file nor a symlink to a regular file".
Nothing had noticed because `packages/cli/src/documents/` is flat. The review
graph keeps its documents under `components/` and `policies/`, so it is the
first, and `packages/code-review-agent` became a CLI dependency in this stack —
which is what put it in the CLI's npm build at all.
Only Node and Bun would have seen it: Deno resolves the assets from the source
tree and stays green, which is why `scripts/tests/cli-npm-bin.test.ts` is where
it surfaced.
Verified by building the package: 30 component documents, 5 policies and
`components.md` land under `npm/esm/src/`.1 parent 932bbe4 commit ba30306
1 file changed
Lines changed: 16 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
77 | 90 | | |
78 | 91 | | |
79 | 92 | | |
| |||
0 commit comments