Repository navigation
Commit b639fab
committed
🐛 Name a file by when it came into being, and read a directory as a set
The two failures CI found on this head, and nothing else.
**An owner's exit removed a replacement it had never published.** `same()`
identified a published attachment file by device and inode. An inode number is
reused, and ext4 on the runner did reuse one: the file this owner wrote was
unlinked, a replacement was created in its place and was handed the same
number, and the exit took it away. `ENOENT` on the read that followed, in both
the Deno and the Bun job.
The correction is the one the dependent layout branch already carries, taken
whole and unchanged: the moment a file came into existence is part of its
identity. Measured here — a creation time is reported, an untouched file keeps
it, and a file created after another was unlinked does not share it. Strictly
stricter, so it can only ever leave a name alone and never remove one this
owner did not publish. This host does not reuse inodes eagerly and so cannot
reproduce the failure itself; the preserved run logs are that evidence.
**A directory was read as a list.** `readdir` of `.acpx` was compared to a
literal pair in one order, and a runner handed the two names back the other way
round. It is sorted now, exactly as the assertion above it already was: what
this row is about is which names are there, and a directory promises nothing
about the order it enumerates them in. The membership is unchanged and nothing
is skipped, slept on or excluded.1 parent b60e58d commit b639fab
2 files changed
Lines changed: 24 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
60 | 78 | | |
61 | | - | |
| 79 | + | |
62 | 80 | | |
63 | 81 | | |
64 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
328 | | - | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
329 | 333 | | |
330 | 334 | | |
331 | 335 | | |
| |||
0 commit comments