You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit acb8656
Browse filesBrowse the repository at this point in the historyBrowse files
♻️ Compose the run profile's elicitation provider instead of flagging it (#607)
Review of 8b380b9: a trusted host profile must install Web elicitation
directly, through lexical composition, rather than by handing the shared
assembly a property to interpret.
`DocumentMode.webElicitation` is gone, and `installDocumentComponents()` no
longer installs an elicitation provider for any command — it neither receives
nor reads a profile. `installWebComponents()` stays unconditional, so
`<WebForm>` remains registered everywhere.
Instead, each profile composes what it owns. `xmd run` installs
`installWebElicitation()` in the scope it assembles around its own document, and
the nested `host="run"` profile installs it in the isolated scope the harness
gives a child — restated there rather than inherited, because a child of
`xmd test` is still the run profile and its command composes none. `xmd test`
and `xmd workflow` compose no elicitation provider at all, so the workflow
attachment's suspending provider stays the only one a workflow document can
reach.
The behavior is the one 8b380b9 established and the four-profile table is
unchanged; what moves is where the decision lives. Absence is now how a profile
says it does not own the question, so there is no flag to read and no default to
inherit.
The subprocess regression is unchanged, and still fails on the defect: with
`installWebElicitation()` moved back into the shared assembly, the case is
abandoned at its deadline with the loopback form URL in its captured output.
0 commit comments