Repository navigation
Commit 944c734
committed
🐛 Refuse a valued --run instead of reading it as the switch (#260)
An option's name is read up to its first `=`, so `--run=false` arrived under the
name of the switch and was taken for it. That set the flag saying execution had
been requested, which is also what satisfies the gate refusing options that only
configure a run — so `--run=false --journal trace.jsonl` was accepted.
What followed is worth stating precisely, because it is not what the flag being
set suggests. The ordinary parser reads `--run=false` as false and `--run=true`
as the field's default, which is also false. So the command took the write path
either way: `--run=false --journal <path>` completed successfully, created no
journal, and never told the caller that the journal they asked for was not a
thing this invocation would produce; and `--run=true` was silently answered by a
command that wrote the Plan instead of running it. One half of the command
believed a run had been requested and the other half did not, and neither told
anybody.
Every valued spelling — `--run=false`, `--run=true`, `--run=` — now fails fixed
preflight, before it establishes that execution was requested and before it can
answer for the gate. Nothing is loaded, built, contacted, opened, created or
executed.
The regressions fail without it: the scanner cases find no error, and the
command-level case exits 0 where it now exits 1 — the old behaviour was a
success, not an incidental failure, which is what makes the tripwires worth
asserting.
Claude-Session: https://claude.ai/code/session_015HcqB9kJM9KFnMNToAuZF61 parent 142272d commit 944c734
4 files changed
Lines changed: 109 additions & 1 deletion
File tree
- packages/cli
- src
- tests
- specs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
231 | 247 | | |
232 | 248 | | |
233 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
272 | 302 | | |
273 | 303 | | |
274 | 304 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
209 | 256 | | |
210 | 257 | | |
211 | 258 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
129 | 144 | | |
130 | 145 | | |
131 | 146 | | |
| |||
574 | 589 | | |
575 | 590 | | |
576 | 591 | | |
577 | | - | |
| 592 | + | |
578 | 593 | | |
579 | 594 | | |
580 | 595 | | |
| |||
0 commit comments